gpu/command_buffer/common/gles2_cmd_utils.h - Issue 1759433002: Update GL_IMPLEMENTATION_COLOR_READ_FORMAT for BGRA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/common/gles2_cmd_utils.h

Issue 1759433002: Update GL_IMPLEMENTATION_COLOR_READ_FORMAT for BGRA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove no longer needed check from GLHelperReadbackSupport::SupportsFormat Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/gl_helper_readback_support.cc ('K') | « content/common/gpu/client/gl_helper_readback_support.cc ('k') | gpu/command_buffer/common/gles2_cmd_utils.cc » ('j') | gpu/command_buffer/common/gles2_cmd_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/common/gles2_cmd_utils.h

diff --git a/gpu/command_buffer/common/gles2_cmd_utils.h b/gpu/command_buffer/common/gles2_cmd_utils.h

index 3c302af9bedcfa95e72e8d283c3e4eae25c425c5..4ff35b5d6318b5bd840dddd66ce1ccd52dace819 100644

--- a/gpu/command_buffer/common/gles2_cmd_utils.h

+++ b/gpu/command_buffer/common/gles2_cmd_utils.h

@@ -175,11 +175,12 @@ class GLES2_UTILS_EXPORT GLES2Util {

static size_t GLTargetToFaceIndex(uint32_t target);

- static uint32_t GetGLReadPixelsImplementationFormat(

- uint32_t internal_format);

+ static uint32_t GetGLReadPixelsAdditionalFormat(uint32_t internal_format,

+ uint32_t texture_type);

- static uint32_t GetGLReadPixelsImplementationType(

- uint32_t internal_format, uint32_t texture_type);

+ static uint32_t GetGLReadPixelsTypeForAdditionalFormat(

+ uint32_t internal_format,

+ uint32_t texture_type);

// Returns a bitmask for the channels the given format supports.

// See ChannelBits.