Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: content/common/gpu/client/gl_helper_readback_support.cc

Issue 1759433002: Update GL_IMPLEMENTATION_COLOR_READ_FORMAT for BGRA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove no longer needed check from GLHelperReadbackSupport::SupportsFormat Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gl_helper_readback_support.cc
diff --git a/content/common/gpu/client/gl_helper_readback_support.cc b/content/common/gpu/client/gl_helper_readback_support.cc
index e773ca90782a6dc684bec38c7afb455e1cfe925c..91df07cb342cc8214c0777f91c59efe675407f3b 100644
--- a/content/common/gpu/client/gl_helper_readback_support.cc
+++ b/content/common/gpu/client/gl_helper_readback_support.cc
@@ -104,17 +104,6 @@ bool GLHelperReadbackSupport::SupportsFormat(GLenum format, GLenum type) {
if (format == GL_RGBA && type == GL_UNSIGNED_BYTE)
return true;
- if (format == GL_BGRA_EXT && type == GL_UNSIGNED_BYTE) {
ericrk 2016/03/02 17:40:30 The presence of GL_EXT_read_format_bgra doesn't gu
- const GLubyte* tmp = gl_->GetString(GL_EXTENSIONS);
- if (tmp) {
- std::string extensions =
- " " + std::string(reinterpret_cast<const char*>(tmp)) + " ";
- if (extensions.find(" GL_EXT_read_format_bgra ") != std::string::npos) {
- return true;
- }
- }
- }
-
bool supports_format = false;
GLenum ext_format = 0, ext_type = 0;
GetAdditionalFormat(format, type, &ext_format, &ext_type);
« no previous file with comments | « no previous file | gpu/command_buffer/common/gles2_cmd_utils.h » ('j') | gpu/command_buffer/common/gles2_cmd_utils.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698