src/x64/macro-assembler-x64.h - Issue 1759383003: [compiler] Add relocatable pointer constants for wasm memory references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.h

Issue 1759383003: [compiler] Add relocatable pointer constants for wasm memory references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Removing additional check Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.h

diff --git a/src/x64/macro-assembler-x64.h b/src/x64/macro-assembler-x64.h

index 039ad8c5c1cefec084e743e846be529f34dbee4d..b1990bac031d642b97d2fd2cce7065562062b8e1 100644

--- a/src/x64/macro-assembler-x64.h

+++ b/src/x64/macro-assembler-x64.h

@@ -818,7 +818,6 @@ class MacroAssembler: public Assembler {

// Load a register with a long value as efficiently as possible.

void Set(Register dst, int64_t x);

- void Set(Register dst, int64_t x, RelocInfo::Mode rmode);

void Set(const Operand& dst, intptr_t x);

void Cvtss2sd(XMMRegister dst, XMMRegister src);

« src/compiler/x64/instruction-selector-x64.cc ('K') | « src/x64/assembler-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | src/x64/macro-assembler-x64.cc » ('J')