src/x64/assembler-x64.cc - Issue 1759383003: [compiler] Add relocatable pointer constants for wasm memory references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.cc

Issue 1759383003: [compiler] Add relocatable pointer constants for wasm memory references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Removing additional check Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64.cc

diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc

index 214b786fede51107ce44282ae36457d2a4bc7e64..fef973f2d8a760a1319263e9c041507d269e2232 100644

--- a/src/x64/assembler-x64.cc

+++ b/src/x64/assembler-x64.cc

@@ -1484,7 +1484,6 @@ void Assembler::movq(Register dst, uint64_t value, RelocInfo::Mode rmode) {

movq(dst, static_cast<int64_t>(value), rmode);

}

// Loads the ip-relative location of the src label into the target location

// (as a 32-bit offset sign extended to 64-bit).

void Assembler::movl(const Operand& dst, Label* src) {

« src/compiler/x64/instruction-selector-x64.cc ('K') | « src/compiler/x64/instruction-selector-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | src/x64/macro-assembler-x64.cc » ('J')