device/nfc/nfc.mojom - Issue 1759373003: [webnfc] Implement nfc.watch in blink nfc module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/nfc/nfc.mojom

Issue 1759373003: [webnfc] Implement nfc.watch in blink nfc module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@implement_nfc_push_in_android

Patch Set: Rebased to master Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/nfc/nfc.mojom

diff --git a/device/nfc/nfc.mojom b/device/nfc/nfc.mojom

index 413be2e4f8e6e9fb8a1dbe72686b8264ab9fd055..3f344a157880b732438186dc4388da813104fc60 100644

--- a/device/nfc/nfc.mojom

+++ b/device/nfc/nfc.mojom

@@ -66,6 +66,9 @@ struct NFCMessage {

// path. It represents Web NFC id, that can be used for matching Web NFC

// content with the filter specified by |url| field in NFCWatchOptions.

string? url;

+ // Maximum size of NFC message that can be sent over IPC is 32KB.

+ const uint32 kMaxSize = 32768;

Tom Sepez 2016/11/21 18:12:34 Where do we check this (on the receiving side)?

shalamov 2016/11/22 12:50:41 It is in another CL: https://codereview.chromium.o

};

struct NFCPushOptions {

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/nfc/push.html » ('j') | third_party/WebKit/Source/modules/nfc/NFC.cpp » ('J')