Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2524743002: [webnfc] Restrict NFC message size to 32KB (Closed)

Created:
4 years ago by shalamov
Modified:
4 years ago
CC:
abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Aaron Boodman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[webnfc] Restrict NFC message size to 32KB This patch limits maximum NFC message size for nfc.push() operation to 32KB. The 32KB limit is selected based on several factors: capacity of consumer NFC tags, data transfer rate and IPC mechanism that is used by mojo service. Layout test is modified to test that promise is rejected for nfc.push() operation when message size exceeds 32KB. BUG=520391 Committed: https://crrev.com/b706a428c0ca98907c6ece6aa80f5ce215381acf Cr-Commit-Position: refs/heads/master@{#434131}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M device/nfc/nfc.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/nfc/push.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 2 chunks +17 lines, -1 line 1 comment Download

Messages

Total messages: 15 (8 generated)
shalamov
Based on feedback from @haraken, I've moved max NFC message size restriction from codereview.chromium.org/1759373003/ to ...
4 years ago (2016-11-22 12:49:25 UTC) #6
kenneth.r.christiansen
lgtm https://codereview.chromium.org/2524743002/diff/1/third_party/WebKit/Source/modules/nfc/NFC.cpp File third_party/WebKit/Source/modules/nfc/NFC.cpp (right): https://codereview.chromium.org/2524743002/diff/1/third_party/WebKit/Source/modules/nfc/NFC.cpp#newcode429 third_party/WebKit/Source/modules/nfc/NFC.cpp:429: size_t getNFCMessageSize( measure instead of get?
4 years ago (2016-11-22 13:11:23 UTC) #7
haraken
LGTM
4 years ago (2016-11-22 14:25:07 UTC) #8
Tom Sepez
lgtm
4 years ago (2016-11-22 16:57:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524743002/1
4 years ago (2016-11-23 08:09:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 08:14:16 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-23 08:16:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b706a428c0ca98907c6ece6aa80f5ce215381acf
Cr-Commit-Position: refs/heads/master@{#434131}

Powered by Google App Engine
This is Rietveld 408576698