Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: tools/perf/core/trybot_command_unittest.py

Issue 1759183003: Create separate list for win and win-64 bisect in order to generate appropriate perf config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/core/trybot_command.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/core/trybot_command_unittest.py
diff --git a/tools/perf/core/trybot_command_unittest.py b/tools/perf/core/trybot_command_unittest.py
index 829f8b2084a555e0994236385906cefe304b5288..a953a38b43787b88d960f5d1c6ad6bb95f6f3c92 100644
--- a/tools/perf/core/trybot_command_unittest.py
+++ b/tools/perf/core/trybot_command_unittest.py
@@ -180,6 +180,9 @@ class TrybotCommandTest(unittest.TestCase):
'linux_perf_bisect': 'otherstuff3',
'win_x64_perf_bisect': 'otherstuff4',
'win_perf_bisect_builder': 'not a trybot',
+ 'win_x64_10_perf_bisect': 'otherstuff4',
+ 'winx64ati_perf_bisect': 'not a trybot',
+ 'winx64nvidia_perf_bisect': 'not a trybot',
})
command = trybot_command.Trybot()
command._InitializeBuilderNames('all-win')
@@ -189,8 +192,13 @@ class TrybotCommandTest(unittest.TestCase):
self.assertEquals(
['win_8_perf_bisect', 'win_perf_bisect'],
sorted(command._builder_names.get('win')))
+ self.assertNotIn(
+ 'win_x64_perf_bisect',
+ sorted(command._builder_names.get('win')))
self.assertEquals(
- ['win_x64_perf_bisect'], sorted(command._builder_names.get('win-x64')))
+ sorted(['win_x64_perf_bisect', 'win_x64_10_perf_bisect',
+ 'winx64ati_perf_bisect', 'winx64nvidia_perf_bisect']),
+ sorted(command._builder_names.get('win-x64')))
def testConstructorTrybotAllAndroid(self):
self._MockTryserverJson({
« no previous file with comments | « tools/perf/core/trybot_command.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698