tools/perf/core/trybot_command.py - Issue 1759183003: Create separate list for win and win-64 bisect in order to generate appropriate perf config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/core/trybot_command.py

Issue 1759183003: Create separate list for win and win-64 bisect in order to generate appropriate perf config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/core/trybot_command.py

diff --git a/tools/perf/core/trybot_command.py b/tools/perf/core/trybot_command.py

index 36f6bd94bcc056bff7a3bb1aa467c51f91acd403..ce9402700ce3e43db26eb272b7cbeb554e40bb83 100644

--- a/tools/perf/core/trybot_command.py

+++ b/tools/perf/core/trybot_command.py

@@ -97,9 +97,11 @@ def _GetBuilderNames(trybot_name, builders):

# Special case for Windows x64, consider it as separate platform

# config config should contain target_arch=x64 and --browser=release_x64.

win_x64_bots = [

- platform_and_bots['win'].pop(i)

- for i, win_bot in enumerate(platform_and_bots['win'])

+ win_bot for win_bot in platform_and_bots['win']

if 'x64' in win_bot]

+ # Separate out non x64 bits win bots

+ platform_and_bots['win'] = list(

+ set(platform_and_bots['win']) - set(win_x64_bots))

platform_and_bots['win-x64'] = win_x64_bots

if 'all-win' in trybot_name:

« no previous file with comments | « no previous file | tools/perf/core/trybot_command_unittest.py » ('j') | no next file with comments »