Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1759133002: [compiler] Initial TurboFan code stubs for abstract relational comparison. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Initial TurboFan code stubs for abstract relational comparison. This adds new code stubs for abstract relational comparison, namely LessThanStub, LessThanOrEqualStub, GreaterThanStub and GreaterThanOrEqualStub, and hooks them up for Ignition and TurboFan. These stubs implement the full compare operation without any unpredictable bailouts. Currently they still go to C++ for string comparisons, and also use the %ToPrimitive_Number runtime entry, as we still lack a stub for the ToPrimitive operation. These issues will be addressed separately in follow-up CLs. Drive-by-fix: Add support for deferred code in the RawMachineAssembler and CodeStubAssembler. A block can be marked as deferred by marking its Label as deferred, which will then make the register allocator penalize this block and prefer better register assignments for the other blocks. R=epertoso@chromium.org Committed: https://crrev.com/62bc168d6e84d053d528c71bb7eb4e5c923feec1 Cr-Commit-Position: refs/heads/master@{#34463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+676 lines, -75 lines) Patch
M src/code-factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/code-stubs.h View 3 chunks +47 lines, -23 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +370 lines, -6 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 6 chunks +41 lines, -7 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 6 chunks +97 lines, -22 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +8 lines, -4 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/interpreter/interpreter.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +72 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-03 13:13:52 UTC) #1
Benedikt Meurer
Hey Enrico, Here's the next bunch of TurboFan code stubs, plus bonus deferred code. :-) ...
4 years, 9 months ago (2016-03-03 13:14:41 UTC) #2
epertoso
lgtm
4 years, 9 months ago (2016-03-03 14:00:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759133002/1
4 years, 9 months ago (2016-03-03 16:36:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 16:39:02 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 16:40:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62bc168d6e84d053d528c71bb7eb4e5c923feec1
Cr-Commit-Position: refs/heads/master@{#34463}

Powered by Google App Engine
This is Rietveld 408576698