Issue 1758333002: [compiler] Introduce code stubs for string relational comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1758333002: [compiler] Introduce code stubs for string relational comparisons. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer

Modified:
4 years, 9 months ago

Reviewers:

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@AbstractRelationalComparison

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[compiler] Introduce code stubs for string relational comparisons. Add StringLessThanStub, StringLessThanOrEqualStub, StringGreaterThanStub and StringGreaterThanOrEqualStub, based on the CodeStubAssembler, and hook them up with TurboFan (and Ignition). The stubs are currently essentially comparable with the StringCompareStub, which is then soon obsolete.

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+343 lines, -89 lines)			Patch
M	src/code-factory.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/code-factory.cc	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View	2 chunks	+39 lines, -0 lines	0 comments	Download
M	src/code-stubs.cc	View	5 chunks	+217 lines, -12 lines	0 comments	Download
M	src/compiler/code-stub-assembler.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/compiler/code-stub-assembler.cc	View	2 chunks	+25 lines, -0 lines	0 comments	Download
M	src/compiler/simplified-lowering.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/compiler/simplified-lowering.cc	View	3 chunks	+30 lines, -57 lines	0 comments	Download
M	test/cctest/compiler/test-simplified-lowering.cc	View	2 chunks	+2 lines, -17 lines	0 comments	Download

Depends on Patchset:

Issue 1759133002 Patch 1