Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1759123003: Revert of Extract state management from WebMediaPlayerImpl. (Closed)

Created:
4 years, 9 months ago by yoichio
Modified:
4 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, halliwell, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Extract state management from WebMediaPlayerImpl. (patchset #32 id:620001 of https://codereview.chromium.org/1641423002/ ) Reason for revert: This CL has made layout tests failed. See: https://bugs.chromium.org/p/chromium/issues/detail?id=591930 Original issue's description: > Extract state management from WebMediaPlayerImpl. > > WMPI recieves operations at any time but is backed by Pipeline which can > only perform one operation at a time. This CL creates a helper class > (PipelineController) to translate between the two so that WMPI does not need > to handle the full cross product of states. > > Committed: https://crrev.com/aafb73c6460349c508a49e6e6de21e774ec80b5c > Cr-Commit-Position: refs/heads/master@{#379168} TBR=dalecurtis@chromium.org,wolenetz@chromium.org,xhwang@chromium.org,sandersd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/863bebf1980b04ce7f1e427df8a0e1307bbd8875 Cr-Commit-Position: refs/heads/master@{#379243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -897 lines) Patch
M media/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +0 lines, -67 lines 0 comments Download
M media/base/mock_filters.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M media/blink/webmediaplayer_cast_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.h View 7 chunks +56 lines, -27 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 19 chunks +302 lines, -114 lines 0 comments Download
D media/filters/pipeline_controller.h View 1 chunk +0 lines, -177 lines 0 comments Download
D media/filters/pipeline_controller.cc View 1 chunk +0 lines, -268 lines 0 comments Download
D media/filters/pipeline_controller_unittest.cc View 1 chunk +0 lines, -212 lines 0 comments Download
M media/media.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
yoichio
Created Revert of Extract state management from WebMediaPlayerImpl.
4 years, 9 months ago (2016-03-04 07:56:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759123003/1
4 years, 9 months ago (2016-03-04 07:56:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 07:57:06 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 07:58:25 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/863bebf1980b04ce7f1e427df8a0e1307bbd8875
Cr-Commit-Position: refs/heads/master@{#379243}

Powered by Google App Engine
This is Rietveld 408576698