Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6526)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

Issue 1758983002: [MD] Remove arrow from location bar bubbles when icon is already showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
index 38783b088c9ba3740ee5a237316a48abeb60833b..9b3f90bdad25d9c0dabe11713d19505fbeecacee 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
#include "content/public/browser/notification_source.h"
+#include "ui/base/material_design/material_design_controller.h"
#include "ui/gfx/geometry/rect.h"
LocationBarBubbleDelegateView::LocationBarBubbleDelegateView(
@@ -31,8 +32,10 @@ LocationBarBubbleDelegateView::~LocationBarBubbleDelegateView() {}
void LocationBarBubbleDelegateView::ShowForReason(DisplayReason reason) {
if (reason == USER_GESTURE) {
- // TODO(estade): re-enable this when crbug.com/518941 is fixed.
- // SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
+ // In the USER_GESTURE case, the icon will be in an active state so the
+ // bubble doesn't need an arrow.
+ if (ui::MaterialDesignController::IsModeMaterial())
+ SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
varkha 2016/03/03 22:52:47 Do you need to do something similar here: https://
varkha 2016/03/04 00:59:57 Posted a CL here: https://codereview.chromium.org/
GetWidget()->Show();
} else {
GetWidget()->ShowInactive();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698