Removes arrow from location bar content bubbles when ink drop is shown

Removes arrow from location bar content bubbles when ink drop is shown

A small followup to https://codereview.chromium.org/1758983002/.

BUG=518941
Committed: https://crrev.com/beebb48a094421624f080efeb4a9fe25460a81ad
Cr-Commit-Position: refs/heads/master@{#379207}

[varkha, 2016-03-04 00:59:16]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 00:59:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762163002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762163002/1

[varkha, 2016-03-04 01:01:00]

varkha@chromium.org changed reviewers:
+ estade@chromium.org, pkasting@chromium.org

[varkha, 2016-03-04 01:01:01]

Can you please take a look? This seems to be missing from
https://codereview.chromium.org/1758983002/.

Thanks!

[commit-bot: I haz the power, 2016-03-04 01:49:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 01:49:46]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2016-03-04 02:21:23]

RS LGTM; I'm not familiar enough with things to know if this is functionally
correct.  If you need someone to think about this in detail you'll need a
different reviewer.

https://codereview.chromium.org/1762163002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right):

https://codereview.chromium.org/1762163002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:262: if
(ui::MaterialDesignController::IsModeMaterial())
Nit: Please add an explanatory comment as was done in
https://codereview.chromium.org/1758983002/diff/20001/chrome/browser/ui/views...
(I don't know from just looking why we don't need an arrow).

[varkha, 2016-03-04 03:28:57]

https://codereview.chromium.org/1762163002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right):

https://codereview.chromium.org/1762163002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:262: if
(ui::MaterialDesignController::IsModeMaterial())
On 2016/03/04 02:21:23, Peter Kasting wrote:
> Nit: Please add an explanatory comment as was done in
>
https://codereview.chromium.org/1758983002/diff/20001/chrome/browser/ui/views...
> (I don't know from just looking why we don't need an arrow).

Done.

[varkha, 2016-03-04 03:29:12]

The CQ bit was checked by varkha@chromium.org

[varkha, 2016-03-04 03:29:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1762163002/#ps20001
(title: "Removes arrow from location bar content bubbles when ink drop is
shown")

[commit-bot: I haz the power, 2016-03-04 03:29:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1762163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1762163002/20001

[commit-bot: I haz the power, 2016-03-04 04:23:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-04 04:25:10]

Description was changed from

==========
Removes arrow from location bar content bubbles when ink drop is shown

A small followup to https://codereview.chromium.org/1758983002/.

BUG=518941
==========

to

==========
Removes arrow from location bar content bubbles when ink drop is shown

A small followup to https://codereview.chromium.org/1758983002/.

BUG=518941

Committed: https://crrev.com/beebb48a094421624f080efeb4a9fe25460a81ad
Cr-Commit-Position: refs/heads/master@{#379207}
==========

[commit-bot: I haz the power, 2016-03-04 04:25:11]

Patchset 2 (id:??) landed as
https://crrev.com/beebb48a094421624f080efeb4a9fe25460a81ad
Cr-Commit-Position: refs/heads/master@{#379207}

[Evan Stade, 2016-03-04 04:25:14]

https://codereview.chromium.org/1762163002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right):

https://codereview.chromium.org/1762163002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:265:
bubble_view_->SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
you can put this in ContentSettingBubbleContents