[MD] Remove arrow from location bar bubbles when icon is already showing

[MD] Remove arrow from location bar bubbles when icon is already showing
a hover state.

This was always the intended behavior but we were previously blocked
from implementing it because location bar icons didn't have the hover
effect yet.

BUG=518941
Committed: https://crrev.com/c3e0d71008f0911b2809e7fdbeeaefd4a6e8ef21
Cr-Commit-Position: refs/heads/master@{#379100}

[Evan Stade, 2016-03-03 01:08:19]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2016-03-03 20:43:29]

LGTM

https://codereview.chromium.org/1758983002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
(right):

https://codereview.chromium.org/1758983002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:35: if
(ui::MaterialDesignController::IsModeMaterial())
Nit: I'd add a comment here, e.g. "Gesture-triggered bubbles will have a hover
state visible on the target icon, so we don't need (or want) to show the arrow."

[Evan Stade, 2016-03-03 21:07:59]

https://codereview.chromium.org/1758983002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
(right):

https://codereview.chromium.org/1758983002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:35: if
(ui::MaterialDesignController::IsModeMaterial())
On 2016/03/03 20:43:28, Peter Kasting wrote:
> Nit: I'd add a comment here, e.g. "Gesture-triggered bubbles will have a hover
> state visible on the target icon, so we don't need (or want) to show the
arrow."

Done.

[Evan Stade, 2016-03-03 21:08:08]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-03-03 21:08:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1758983002/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2016-03-03 21:08:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1758983002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1758983002/20001

[commit-bot: I haz the power, 2016-03-03 21:48:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-03 21:49:46]

Description was changed from

==========
[MD] Remove arrow from location bar bubbles when icon is already showing
a hover state.

This was always the intended behavior but we were previously blocked
from implementing it because location bar icons didn't have the hover
effect yet.

BUG=518941
==========

to

==========
[MD] Remove arrow from location bar bubbles when icon is already showing
a hover state.

This was always the intended behavior but we were previously blocked
from implementing it because location bar icons didn't have the hover
effect yet.

BUG=518941

Committed: https://crrev.com/c3e0d71008f0911b2809e7fdbeeaefd4a6e8ef21
Cr-Commit-Position: refs/heads/master@{#379100}
==========

[commit-bot: I haz the power, 2016-03-03 21:49:47]

Patchset 2 (id:??) landed as
https://crrev.com/c3e0d71008f0911b2809e7fdbeeaefd4a6e8ef21
Cr-Commit-Position: refs/heads/master@{#379100}

[varkha, 2016-03-03 22:52:47]

varkha@chromium.org changed reviewers:
+ varkha@chromium.org

[varkha, 2016-03-03 22:52:47]

https://codereview.chromium.org/1758983002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
(right):

https://codereview.chromium.org/1758983002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:38:
SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
Do you need to do something similar here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[varkha, 2016-03-04 00:59:57]

https://codereview.chromium.org/1758983002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
(right):

https://codereview.chromium.org/1758983002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:38:
SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
On 2016/03/03 22:52:47, varkha wrote:
> Do you need to do something similar here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

Posted a CL here: https://codereview.chromium.org/1762163002.