 Chromium Code Reviews
 Chromium Code Reviews Issue 1758973002:
  MD Settings: Creating a <settings-dialog> element.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1758973002:
  MD Settings: Creating a <settings-dialog> element.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/resources/settings/reset_page/reset_profile_dialog.html | 
| diff --git a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html | 
| index 4afb5c259f4daba2c3113fc4e15a510f841aa3ed..a34a006a47b58d6c24718139f1687caafdcdcc75 100644 | 
| --- a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html | 
| +++ b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html | 
| @@ -2,39 +2,30 @@ | 
| <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout.html"> | 
| <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html"> | 
| <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-checkbox.html"> | 
| -<link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog/paper-dialog.html"> | 
| -<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html"> | 
| <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spinner.html"> | 
| -<link rel="import" href="chrome://md-settings/settings_dialog_css.html"> | 
| +<link rel="import" href="chrome://md-settings/settings_dialog.html"> | 
| +<link rel="import" href="chrome://md-settings/settings_shared_css.html"> | 
| <dom-module id="settings-reset-profile-dialog"> | 
| <link rel="import" type="css" href="reset_page_dialog.css"> | 
| <link rel="import" type="css" href="reset_profile_dialog.css"> | 
| <template> | 
| - <style include="settings-dialog"></style> | 
| - <paper-dialog modal id="dialog"> | 
| - <div id="dialog-content"> | 
| - <div class="top-row"> | 
| - <span class="title" i18n-content="resetPageTitle"></span> | 
| - <paper-icon-button icon="clear" on-tap="onCancelTap_" id="close"> | 
| - </paper-icon-button> | 
| - </div> | 
| - <div class="body"> | 
| - <div class="explanation"> | 
| - <span i18n-content="resetPageExplanation"></span> | 
| - <a i18n-values="href:resetPageLearnMoreUrl" | 
| - i18n-content="learnMore" target="_blank"></a> | 
| - </div> | 
| - <div class="button-container"> | 
| - <paper-spinner id="resetSpinner"></paper-spinner> | 
| - <paper-button class="cancel-button" on-tap="onCancelTap_" | 
| - id="cancel" i18n-content="cancel"></paper-button> | 
| - <paper-button class="action-button" on-tap="onResetTap_" | 
| - id="reset" i18n-content="resetPageCommit"></paper-button> | 
| - </div> | 
| - </div> | 
| + <style include="settings-shared"></style> | 
| + <settings-dialog id="dialog"> | 
| 
michaelpg
2016/03/03 02:28:04
so now our dialogs will wrap a <settings-dialog> w
 
dpapad
2016/03/03 19:25:47
Done, removed usage of paper-dialog, using PaperDi
 | 
| + <div class="title" i18n-content="resetPageTitle"></div> | 
| + <div class="body"> | 
| + <span i18n-content="resetPageExplanation"></span> | 
| + <a i18n-values="href:resetPageLearnMoreUrl" | 
| + i18n-content="learnMore" target="_blank"></a> | 
| + </div> | 
| + <div class="button-container"> | 
| + <paper-spinner id="resetSpinner"></paper-spinner> | 
| + <paper-button class="cancel-button" on-tap="onCancelTap_" | 
| + id="cancel" i18n-content="cancel"></paper-button> | 
| + <paper-button class="action-button" on-tap="onResetTap_" | 
| + id="reset" i18n-content="resetPageCommit"></paper-button> | 
| </div> | 
| - <div id="feedbackBar"> | 
| + <div class="footer"> | 
| <paper-checkbox id="sendSettings" i18n-content="resetPageFeedback" | 
| checked on-change="onSendSettingsChange_"></paper-checkbox> | 
| <div id="settings"> | 
| @@ -43,7 +34,7 @@ | 
| </template> | 
| </div> | 
| </div> | 
| - </paper-dialog> | 
| + </settings-dialog> | 
| </template> | 
| <script src="reset_profile_dialog.js"></script> | 
| </dom-module> |