 Chromium Code Reviews
 Chromium Code Reviews Issue 1758973002:
  MD Settings: Creating a <settings-dialog> element.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1758973002:
  MD Settings: Creating a <settings-dialog> element.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW | 
|---|---|
| 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> | 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> | 
| 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> | 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> | 
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 
| 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> | 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> | 
| 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog/paper-dial og.html"> | |
| 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> | |
| 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html"> | 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html"> | 
| 8 <link rel="import" href="chrome://md-settings/settings_dialog_css.html"> | 6 <link rel="import" href="chrome://md-settings/settings_dialog.html"> | 
| 7 <link rel="import" href="chrome://md-settings/settings_shared_css.html"> | |
| 9 | 8 | 
| 10 <dom-module id="settings-reset-profile-dialog"> | 9 <dom-module id="settings-reset-profile-dialog"> | 
| 11 <link rel="import" type="css" href="reset_page_dialog.css"> | 10 <link rel="import" type="css" href="reset_page_dialog.css"> | 
| 12 <link rel="import" type="css" href="reset_profile_dialog.css"> | 11 <link rel="import" type="css" href="reset_profile_dialog.css"> | 
| 13 <template> | 12 <template> | 
| 14 <style include="settings-dialog"></style> | 13 <style include="settings-shared"></style> | 
| 15 <paper-dialog modal id="dialog"> | 14 <settings-dialog id="dialog"> | 
| 
michaelpg
2016/03/03 02:28:04
so now our dialogs will wrap a <settings-dialog> w
 
dpapad
2016/03/03 19:25:47
Done, removed usage of paper-dialog, using PaperDi
 | |
| 16 <div id="dialog-content"> | 15 <div class="title" i18n-content="resetPageTitle"></div> | 
| 17 <div class="top-row"> | 16 <div class="body"> | 
| 18 <span class="title" i18n-content="resetPageTitle"></span> | 17 <span i18n-content="resetPageExplanation"></span> | 
| 19 <paper-icon-button icon="clear" on-tap="onCancelTap_" id="close"> | 18 <a i18n-values="href:resetPageLearnMoreUrl" | 
| 20 </paper-icon-button> | 19 i18n-content="learnMore" target="_blank"></a> | 
| 21 </div> | |
| 22 <div class="body"> | |
| 23 <div class="explanation"> | |
| 24 <span i18n-content="resetPageExplanation"></span> | |
| 25 <a i18n-values="href:resetPageLearnMoreUrl" | |
| 26 i18n-content="learnMore" target="_blank"></a> | |
| 27 </div> | |
| 28 <div class="button-container"> | |
| 29 <paper-spinner id="resetSpinner"></paper-spinner> | |
| 30 <paper-button class="cancel-button" on-tap="onCancelTap_" | |
| 31 id="cancel" i18n-content="cancel"></paper-button> | |
| 32 <paper-button class="action-button" on-tap="onResetTap_" | |
| 33 id="reset" i18n-content="resetPageCommit"></paper-button> | |
| 34 </div> | |
| 35 </div> | |
| 36 </div> | 20 </div> | 
| 37 <div id="feedbackBar"> | 21 <div class="button-container"> | 
| 22 <paper-spinner id="resetSpinner"></paper-spinner> | |
| 23 <paper-button class="cancel-button" on-tap="onCancelTap_" | |
| 24 id="cancel" i18n-content="cancel"></paper-button> | |
| 25 <paper-button class="action-button" on-tap="onResetTap_" | |
| 26 id="reset" i18n-content="resetPageCommit"></paper-button> | |
| 27 </div> | |
| 28 <div class="footer"> | |
| 38 <paper-checkbox id="sendSettings" i18n-content="resetPageFeedback" | 29 <paper-checkbox id="sendSettings" i18n-content="resetPageFeedback" | 
| 39 checked on-change="onSendSettingsChange_"></paper-checkbox> | 30 checked on-change="onSendSettingsChange_"></paper-checkbox> | 
| 40 <div id="settings"> | 31 <div id="settings"> | 
| 41 <template is="dom-repeat" items="[[feedbackInfo_]]"> | 32 <template is="dom-repeat" items="[[feedbackInfo_]]"> | 
| 42 <div><span>[[item.key]]</span>: <span>[[item.value]]</span></div> | 33 <div><span>[[item.key]]</span>: <span>[[item.value]]</span></div> | 
| 43 </template> | 34 </template> | 
| 44 </div> | 35 </div> | 
| 45 </div> | 36 </div> | 
| 46 </paper-dialog> | 37 </settings-dialog> | 
| 47 </template> | 38 </template> | 
| 48 <script src="reset_profile_dialog.js"></script> | 39 <script src="reset_profile_dialog.js"></script> | 
| 49 </dom-module> | 40 </dom-module> | 
| OLD | NEW |