Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1758943002: Add Gerrit's Change-Id handling to git_footers. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
Reviewers:
Bons, Paweł Hajdan Jr.
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Gerrit's Change-Id handling to git_footers. This should insert the message according to Gerrit's own commit-msg hook implementation. BUG=579183 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299093

Patch Set 1 #

Patch Set 2 : nitfix #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M git_footers.py View 1 chunk +38 lines, -0 lines 0 comments Download
M tests/git_footers_test.py View 1 1 chunk +30 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1757133002 Patch 60001
Issue 1757133002 Patch 80001
Issue 1757133002 Patch 100001

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758943002/1
4 years, 9 months ago (2016-03-02 23:38:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758943002/20001
4 years, 9 months ago (2016-03-02 23:44:36 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 23:51:47 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758943002/40001
4 years, 9 months ago (2016-03-03 02:32:35 UTC) #10
tandrii(chromium)
PTAL sadly bauerb@ is OOO till March
4 years, 9 months ago (2016-03-03 02:35:54 UTC) #12
Bons
lgtm
4 years, 9 months ago (2016-03-03 02:41:05 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 02:46:45 UTC) #15
Paweł Hajdan Jr.
LGTM
4 years, 9 months ago (2016-03-03 10:11:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758943002/40001
4 years, 9 months ago (2016-03-04 11:56:46 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 11:59:30 UTC) #20
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299093

Powered by Google App Engine
This is Rietveld 408576698