Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1757133002: git cl: add python implementation of Change-Id generation. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
Reviewers:
Bons, Paweł Hajdan Jr.
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@G050
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git cl: add python implementation of Change-Id generation. This allows to generate new IDs on the fly without installing commit-msg hook and works just fine on Windows. BUG=579183 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299094

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : win may like it more #

Patch Set 6 : fix-tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M git_cl.py View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
M tests/git_cl_test.py View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757133002/1
4 years, 9 months ago (2016-03-02 23:38:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757133002/20001
4 years, 9 months ago (2016-03-02 23:45:41 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757133002/40001
4 years, 9 months ago (2016-03-02 23:48:26 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 23:57:18 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757133002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757133002/80001
4 years, 9 months ago (2016-03-03 02:32:23 UTC) #10
tandrii(chromium)
PTAL The main motivation is to make it work nicely on windows, where calling commit-hook ...
4 years, 9 months ago (2016-03-03 02:50:06 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/525)
4 years, 9 months ago (2016-03-03 02:59:54 UTC) #14
Bons
lgtm
4 years, 9 months ago (2016-03-03 03:15:14 UTC) #15
Paweł Hajdan Jr.
LGTM
4 years, 9 months ago (2016-03-03 10:11:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757133002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757133002/100001
4 years, 9 months ago (2016-03-04 12:00:45 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757133002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757133002/100001
4 years, 9 months ago (2016-03-04 12:01:33 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 12:03:05 UTC) #23
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299094

Powered by Google App Engine
This is Rietveld 408576698