Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2364)

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 1758923002: MD Settings: Align rows underneath settings-checkboxes with the settings-checkbox labels (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/controls/settings_checkbox.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_shared_css.html
diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html
index 1d456c9c05c90bcb4fb4aa54c6cf567af34a92d5..dc700d9f65ffd311c7aa3bc3fe010082224e4903 100644
--- a/chrome/browser/resources/settings/settings_shared_css.html
+++ b/chrome/browser/resources/settings/settings_shared_css.html
@@ -11,6 +11,9 @@
<template>
<style>
:root {
+ --checkbox-margin-start: 2px;
+ --checkbox-size: 16px;
+ --checkbox-spacing: 18px;
--settings-secondary: {
color: var(--paper-grey-500);
font-weight: 400;
@@ -127,11 +130,8 @@
padding-top: 0;
}
- .list-frame select {
- -webkit-margin-start: 4px;
- }
-
- .list-frame .secondary {
+ .list-frame .secondary,
+ .list-item .secondary {
@apply(--settings-secondary);
}
@@ -142,19 +142,16 @@
padding: 0;
}
- /* This button has no ink ripple */
- .list-item.list-button {
- @apply(--layout-center);
- color: var(--google-blue-500);
- font-weight: 500;
- }
-
.list-item iron-icon {
@apply(--layout-center);
height: 20px;
width: 20px;
}
+ .list-item select {
+ -webkit-margin-start: 4px;
+ }
+
.list-item > .middle {
flex: 1;
margin: 8px 12px;
@@ -247,6 +244,13 @@
.vertical-list > div {
border-top: 1px solid var(--paper-grey-300);
}
+
+ .settings-checkbox-spacer {
+ -webkit-margin-start: calc(
michaelpg 2016/03/02 21:53:06 This, um, apparently works, both in native CSS in
Dan Beam 2016/03/02 22:04:32 yeah, i did something like this in downloads (but
+ var(--checkbox-margin-start) +
+ var(--checkbox-size) +
+ var(--checkbox-spacing));
+ }
</style>
</template>
</dom-module>
« no previous file with comments | « chrome/browser/resources/settings/controls/settings_checkbox.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698