src/frames.h - Issue 17589022: Do not iterate stack handlers in SafeStackFrameIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.h

Issue 17589022: Do not iterate stack handlers in SafeStackFrameIterator (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Strengthened checks in the test as suggested Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.h

diff --git a/src/frames.h b/src/frames.h

index 4d4b7ea83ad789dde3c5db9e2ae10f4641e9cfd9..91a8b12e28dfbabede86e6d97d09ab0291eca259 100644

--- a/src/frames.h

+++ b/src/frames.h

@@ -919,7 +919,6 @@ class SafeStackFrameIterator BASE_EMBEDDED {

bool IsValidStackAddress(Address addr) const {

return stack_validator_.IsValid(addr);

}

- bool CanIterateHandles(StackFrame* frame, StackHandler* handler);

bool IsValidFrame(StackFrame* frame) const;

bool IsValidCaller(StackFrame* frame);

static bool IsValidTop(Isolate* isolate,

« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »