Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Side by Side Diff: src/frames.h

Issue 17589022: Do not iterate stack handlers in SafeStackFrameIterator (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Strengthened checks in the test as suggested Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 901 matching lines...) Expand 10 before | Expand all | Expand 10 after
912 ExitFrameValidator(Address low_bound, Address high_bound) 912 ExitFrameValidator(Address low_bound, Address high_bound)
913 : validator_(low_bound, high_bound) { } 913 : validator_(low_bound, high_bound) { }
914 bool IsValidFP(Address fp); 914 bool IsValidFP(Address fp);
915 private: 915 private:
916 StackAddressValidator validator_; 916 StackAddressValidator validator_;
917 }; 917 };
918 918
919 bool IsValidStackAddress(Address addr) const { 919 bool IsValidStackAddress(Address addr) const {
920 return stack_validator_.IsValid(addr); 920 return stack_validator_.IsValid(addr);
921 } 921 }
922 bool CanIterateHandles(StackFrame* frame, StackHandler* handler);
923 bool IsValidFrame(StackFrame* frame) const; 922 bool IsValidFrame(StackFrame* frame) const;
924 bool IsValidCaller(StackFrame* frame); 923 bool IsValidCaller(StackFrame* frame);
925 static bool IsValidTop(Isolate* isolate, 924 static bool IsValidTop(Isolate* isolate,
926 Address low_bound, Address high_bound); 925 Address low_bound, Address high_bound);
927 926
928 StackAddressValidator stack_validator_; 927 StackAddressValidator stack_validator_;
929 const bool is_valid_top_; 928 const bool is_valid_top_;
930 const bool is_valid_fp_; 929 const bool is_valid_fp_;
931 bool iteration_done_; 930 bool iteration_done_;
932 StackFrameIterator iterator_; 931 StackFrameIterator iterator_;
(...skipping 13 matching lines...) Expand all
946 }; 945 };
947 946
948 947
949 // Reads all frames on the current stack and copies them into the current 948 // Reads all frames on the current stack and copies them into the current
950 // zone memory. 949 // zone memory.
951 Vector<StackFrame*> CreateStackMap(Isolate* isolate, Zone* zone); 950 Vector<StackFrame*> CreateStackMap(Isolate* isolate, Zone* zone);
952 951
953 } } // namespace v8::internal 952 } } // namespace v8::internal
954 953
955 #endif // V8_FRAMES_H_ 954 #endif // V8_FRAMES_H_
OLDNEW
« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698