Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1758813002: MIPS: Fix TF EmitPrepareArguments after 85c735729870be01b3e98ccacda1c37dc0076b31. (Closed)

Created:
4 years, 9 months ago by akos.palfi.imgtec
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix TF EmitPrepareArguments after 85c735729870be01b3e98ccacda1c37dc0076b31. Avoid pushing null arguments. BUG= TEST=cctest/test-run-machops/RunCallCFunction8 Committed: https://crrev.com/c854853bee92d67c23ba15ef2c4d7dd42cfe6597 Cr-Commit-Position: refs/heads/master@{#34439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
akos.palfi.imgtec
PTAL.
4 years, 9 months ago (2016-03-02 16:19:47 UTC) #2
balazs.kilvady
lgtm.
4 years, 9 months ago (2016-03-02 16:58:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758813002/1
4 years, 9 months ago (2016-03-02 16:59:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 17:19:09 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 17:20:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c854853bee92d67c23ba15ef2c4d7dd42cfe6597
Cr-Commit-Position: refs/heads/master@{#34439}

Powered by Google App Engine
This is Rietveld 408576698