Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: src/compiler/mips/instruction-selector-mips.cc

Issue 1758813002: MIPS: Fix TF EmitPrepareArguments after 85c735729870be01b3e98ccacda1c37dc0076b31. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/base/bits.h" 6 #include "src/base/bits.h"
7 #include "src/compiler/instruction-selector-impl.h" 7 #include "src/compiler/instruction-selector-impl.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 10
(...skipping 839 matching lines...) Expand 10 before | Expand all | Expand 10 after
850 850
851 // Prepare for C function call. 851 // Prepare for C function call.
852 if (descriptor->IsCFunctionCall()) { 852 if (descriptor->IsCFunctionCall()) {
853 Emit(kArchPrepareCallCFunction | 853 Emit(kArchPrepareCallCFunction |
854 MiscField::encode(static_cast<int>(descriptor->CParameterCount())), 854 MiscField::encode(static_cast<int>(descriptor->CParameterCount())),
855 0, nullptr, 0, nullptr); 855 0, nullptr, 0, nullptr);
856 856
857 // Poke any stack arguments. 857 // Poke any stack arguments.
858 int slot = kCArgSlotCount; 858 int slot = kCArgSlotCount;
859 for (PushParameter input : (*arguments)) { 859 for (PushParameter input : (*arguments)) {
860 Emit(kMipsStoreToStackSlot, g.NoOutput(), g.UseRegister(input.node()), 860 if (input.node()) {
861 g.TempImmediate(slot << kPointerSizeLog2)); 861 Emit(kMipsStoreToStackSlot, g.NoOutput(), g.UseRegister(input.node()),
862 ++slot; 862 g.TempImmediate(slot << kPointerSizeLog2));
863 ++slot;
864 }
863 } 865 }
864 } else { 866 } else {
865 // Possibly align stack here for functions. 867 // Possibly align stack here for functions.
866 int push_count = static_cast<int>(descriptor->StackParameterCount()); 868 int push_count = static_cast<int>(descriptor->StackParameterCount());
867 if (push_count > 0) { 869 if (push_count > 0) {
868 Emit(kMipsStackClaim, g.NoOutput(), 870 Emit(kMipsStackClaim, g.NoOutput(),
869 g.TempImmediate(push_count << kPointerSizeLog2)); 871 g.TempImmediate(push_count << kPointerSizeLog2));
870 } 872 }
871 for (size_t n = 0; n < arguments->size(); ++n) { 873 for (size_t n = 0; n < arguments->size(); ++n) {
872 PushParameter input = (*arguments)[n]; 874 PushParameter input = (*arguments)[n];
(...skipping 517 matching lines...) Expand 10 before | Expand all | Expand 10 after
1390 MachineOperatorBuilder::kFloat32Max | 1392 MachineOperatorBuilder::kFloat32Max |
1391 MachineOperatorBuilder::kFloat32RoundDown | 1393 MachineOperatorBuilder::kFloat32RoundDown |
1392 MachineOperatorBuilder::kFloat32RoundUp | 1394 MachineOperatorBuilder::kFloat32RoundUp |
1393 MachineOperatorBuilder::kFloat32RoundTruncate | 1395 MachineOperatorBuilder::kFloat32RoundTruncate |
1394 MachineOperatorBuilder::kFloat32RoundTiesEven; 1396 MachineOperatorBuilder::kFloat32RoundTiesEven;
1395 } 1397 }
1396 1398
1397 } // namespace compiler 1399 } // namespace compiler
1398 } // namespace internal 1400 } // namespace internal
1399 } // namespace v8 1401 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698