Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1996)

Unified Diff: dart/tests/compiler/dart2js/analyze_dart2js_test.dart

Issue 17588005: Warn about overriding operator== but not hashCode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update comments (according to my dictionary whitelist is a word). Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/compiler/dart2js/analyze_dart2js_test.dart
diff --git a/dart/tests/compiler/dart2js/analyze_dart2js_test.dart b/dart/tests/compiler/dart2js/analyze_dart2js_test.dart
index cb66fdf9959c35d4e9b6651b8c370e8442edb963..a71bd402043d683bc11cbbb9f58481657214fe36 100644
--- a/dart/tests/compiler/dart2js/analyze_dart2js_test.dart
+++ b/dart/tests/compiler/dart2js/analyze_dart2js_test.dart
@@ -20,6 +20,86 @@ import 'analyze_helper.dart';
// TODO(johnniwinther): Support canonical URIs as keys and message kinds as
// values.
const Map<String,List<String>> WHITE_LIST = const {
+ 'sdk/lib/_internal/compiler/implementation/constants.dart':
Johnni Winther 2013/06/28 14:14:55 Nice catch!
+ const [
+ 'Hint: The class "PrimitiveConstant" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/dart_types.dart':
+ const [
+ 'Hint: The class "MalformedType" overrides "operator==", '
+ 'but not "get hashCode".',
+ 'Hint: The class "InterfaceType" overrides "operator==", '
+ 'but not "get hashCode".',
+ 'Hint: The class "TypedefType" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+
+ 'sdk/lib/_internal/compiler/implementation/ssa/types.dart':
+ const [
+ 'Hint: The class "HBoundedType" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart':
+ const [
+ 'Hint: The class "IntValue" overrides "operator==", '
+ 'but not "get hashCode".',
+ 'Hint: The class "InstructionValue" overrides "operator==", '
+ 'but not "get hashCode".',
+ 'Hint: The class "AddValue" overrides "operator==", '
+ 'but not "get hashCode".',
+ 'Hint: The class "SubtractValue" overrides "operator==", '
+ 'but not "get hashCode".',
+ 'Hint: The class "NegateValue" overrides "operator==", '
+ 'but not "get hashCode".',
+ 'Hint: The class "Range" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/tree/dartstring.dart':
+ const [
+ 'Hint: The class "DartString" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/types/container_type_mask.dart':
+ const [
+ 'Hint: The class "ContainerTypeMask" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/types/element_type_mask.dart':
+ const [
+ 'Hint: The class "ElementTypeMask" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart':
+ const [
+ 'Hint: The class "ArgumentsTypes" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/types/union_type_mask.dart':
+ const [
+ 'Hint: The class "UnionTypeMask" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/universe/side_effects.dart':
+ const [
+ 'Hint: The class "SideEffects" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/util/link.dart':
+ const [
+ 'Hint: The class "Link" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/util/link_implementation.dart':
+ const [
+ 'Hint: The class "LinkEntry" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
+ 'sdk/lib/_internal/compiler/implementation/warnings.dart':
+ const [
+ 'Hint: The class "Message" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
};
void main() {

Powered by Google App Engine
This is Rietveld 408576698