Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: dart/tests/compiler/dart2js/analyze_api_test.dart

Issue 17588005: Warn about overriding operator== but not hashCode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update comments (according to my dictionary whitelist is a word). Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/compiler/dart2js/analyze_api_test.dart
diff --git a/dart/tests/compiler/dart2js/analyze_api_test.dart b/dart/tests/compiler/dart2js/analyze_api_test.dart
index 5c6da035ea74bd7a1d0623216d7980de79f98866..e7d7e241c5429f4cc813e9f645904ca6d59be26e 100644
--- a/dart/tests/compiler/dart2js/analyze_api_test.dart
+++ b/dart/tests/compiler/dart2js/analyze_api_test.dart
@@ -21,8 +21,16 @@ import 'analyze_helper.dart';
// values.
const Map<String, List<String>> WHITE_LIST = const {
'path_observer.dart':
- const ['Warning: Using "new Symbol"', // Issue 10565.
+ const ['Hint: Using "new Symbol"', // Issue 10565.
],
+ 'sdk/lib/html/dart2js/html_dart2js.dart':
Johnni Winther 2013/06/28 14:14:55 Have these been reported as bugs? (Please add issu
ahe 2013/06/28 17:59:27 Done.
+ const ['Hint: The class "Rect" overrides "operator==", '
+ 'but not "get hashCode".',
+ 'Hint: The class "Point" overrides "operator==", '
+ 'but not "get hashCode".',
+ 'Hint: The class "_ClientRect" overrides "operator==", '
+ 'but not "get hashCode".',
+ ],
};
void main() {

Powered by Google App Engine
This is Rietveld 408576698