Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1758773002: [crankshaft] Move CompilationPhase into separate file. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-api-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Move CompilationPhase into separate file. The CompilationPhase helper class is only used in Crankshaft and is not suitable for use in other compilers. This factors is out into a separate file and moves it into the "crankshaft" directory. R=jkummerow@chromium.org Committed: https://crrev.com/8377ce95528a4b2de61c9799cd3e94ee96d4e346 Cr-Commit-Position: refs/heads/master@{#34441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -54 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.h View 1 chunk +0 lines, -24 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -30 lines 0 comments Download
A src/crankshaft/compilation-phase.h View 1 chunk +41 lines, -0 lines 0 comments Download
A src/crankshaft/compilation-phase.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/lithium.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/lithium-allocator.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-02 16:16:09 UTC) #1
Jakob Kummerow
LGTM (rubberstamping CompilationPhase class, assuming it's just been moved).
4 years, 9 months ago (2016-03-02 17:07:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758773002/1
4 years, 9 months ago (2016-03-02 17:28:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 17:30:40 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 17:32:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8377ce95528a4b2de61c9799cd3e94ee96d4e346
Cr-Commit-Position: refs/heads/master@{#34441}

Powered by Google App Engine
This is Rietveld 408576698