Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1756183002: [crankshaft] Remove graph builder from optimized compile job. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Remove graph builder from optimized compile job. There is no reason to keep around the HOptimizedGraphBuilder after the graph has successfully been built. Later phases in OptimizedCompileJob should not rely on it anymore. R=jkummerow@chromium.org Committed: https://crrev.com/56eca6d3152f3310b7b029df15baf1740ae9b581 Cr-Commit-Position: refs/heads/master@{#34440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/compiler.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/compiler.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-02 16:02:37 UTC) #1
Jakob Kummerow
LGTM % bot happiness
4 years, 9 months ago (2016-03-02 17:04:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756183002/1
4 years, 9 months ago (2016-03-02 17:16:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 17:27:12 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 17:27:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56eca6d3152f3310b7b029df15baf1740ae9b581
Cr-Commit-Position: refs/heads/master@{#34440}

Powered by Google App Engine
This is Rietveld 408576698