Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1758653004: [GN] Set testonly unconditionally. (Closed)

Created:
4 years, 9 months ago by jbroman
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
blink-reviews, chromium-reviews, kinuko+watch, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Set testonly unconditionally. Blink unit test code is no longer linked into blink_web in component builds: https://chromium.googlesource.com/chromium/src.git/+/737c4d03 Thus the hack to only mark targets as testonly in non-component builds is no longer required, and `gn check` continues to pass in component builds. BUG=412064, 590749 Committed: https://crrev.com/d2f87840e21d49e5580d58dc0ecbf26bf0802a47 Cr-Commit-Position: refs/heads/master@{#379020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M base/test/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M build/secondary/testing/gmock/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M build/secondary/testing/gtest/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jbroman
4 years, 9 months ago (2016-03-02 20:57:27 UTC) #2
brettw
Yay! LGTM
4 years, 9 months ago (2016-03-02 21:14:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758653004/1
4 years, 9 months ago (2016-03-03 14:28:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758653004/1
4 years, 9 months ago (2016-03-03 15:54:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 16:41:58 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 16:43:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2f87840e21d49e5580d58dc0ecbf26bf0802a47
Cr-Commit-Position: refs/heads/master@{#379020}

Powered by Google App Engine
This is Rietveld 408576698