build/secondary/testing/gtest/BUILD.gn - Issue 1758653004: [GN] Set testonly unconditionally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/testing/gtest/BUILD.gn

Issue 1758653004: [GN] Set testonly unconditionally. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/testing/gtest/BUILD.gn

diff --git a/build/secondary/testing/gtest/BUILD.gn b/build/secondary/testing/gtest/BUILD.gn

index 8e5cdcccede667ffd151cfb0d652dc1cd00bcc7a..13d49f124686b4d67434b44c5a34c5d527f77c1f 100644

--- a/build/secondary/testing/gtest/BUILD.gn

+++ b/build/secondary/testing/gtest/BUILD.gn

@@ -68,8 +68,7 @@ config("gtest_warnings") {

}

static_library("gtest") {

- # TODO http://crbug.com/412064 enable this flag all the time.

- testonly = !is_component_build

+ testonly = true

sources = [

"include/gtest/gtest-death-test.h",

"include/gtest/gtest-message.h",

@@ -139,8 +138,7 @@ static_library("gtest") {

}

source_set("gtest_main") {

- # TODO http://crbug.com/412064 enable this flag all the time.

- testonly = !is_component_build

+ testonly = true

sources = [

"src/gtest_main.cc",

]

« no previous file with comments | « build/secondary/testing/gmock/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »