Add source position information to profile

Add source position information to profile

- Fix bug in inlined call token positios.
- Add ProfileFunctionSourcePosition for tracking source positions within functions.
- Keep a list of ProfileFunctionSourcePosition in each function.
- Add unit test helper functions.
- Add unoptimized unit tests that verify source positions in function profiles.
- Add optimized/inlined unit tests that verify source positions in function profiles.

R=srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/58e0ef13fa77cbb52185abd1e92d5341f46b5ae8

[Cutch, 2016-03-02 17:49:44]

Description was changed from

==========
Add source position information to profile

BUG=
==========

to

==========
Add source position information to profile

- Fix bug in inlined call token positios.
- Add ProfileFunctionSourcePosition for tracking source positions within
functions.
- Keep a list of ProfileFunctionSourcePosition in each function.
- Add unit test helper functions.
- Add unoptimized unit tests that verify source positions in function profiles.
- Add optimized/inlined unit tests that verify source positions in function
profiles.
==========

[Cutch, 2016-03-02 17:49:44]

johnmccutchan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2016-03-02 19:02:56]

lgtm

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:704: // We do not add the token position now because we
don't know the
Maybe add comment that we expect all token positions to be at a call.

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:545: if (prev_inlining_id <
inline_id_to_token_pos_.length()) {
Add comment something like: id_to_token_pos is added later when encountering a
call

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/flow_graph_i...
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/flow_graph_i...
runtime/vm/flow_graph_inliner.cc:1965: ASSERT(inline_id_to_token_pos_->length()
==
s/function/functions/

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_ser...
File runtime/vm/profiler_service.h (right):

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.h:45: TokenPosition token_pos_;
const

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.h:47: intptr_t inclusive_ticks_;
DISALLOW_ALLOCATION

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.h:101: bool
GetSinglePosition(ProfileFunctionSourcePosition* pfsp);
Add comment about when is true/false returned.

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_tes...
File runtime/vm/profiler_test.cc (right):

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_tes...
runtime/vm/profiler_test.cc:1941: TEST_CASE(Profiler_SourcePositionOptimized) {
Disable background compilation

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_tes...
runtime/vm/profiler_test.cc:2170:
TEST_CASE(Profiler_BinaryOperatorSourcePositionOptimized) {
Disable background compilation

[Cutch, 2016-03-02 19:14:08]

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:704: // We do not add the token position now because we
don't know the
On 2016/03/02 19:02:55, srdjan wrote:
> Maybe add comment that we expect all token positions to be at a call.

Done.

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:545: if (prev_inlining_id <
inline_id_to_token_pos_.length()) {
On 2016/03/02 19:02:55, srdjan wrote:
> Add comment something like: id_to_token_pos is added later when encountering a
> call

Done.

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/flow_graph_i...
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/flow_graph_i...
runtime/vm/flow_graph_inliner.cc:1965: ASSERT(inline_id_to_token_pos_->length()
==
On 2016/03/02 19:02:55, srdjan wrote:
> s/function/functions/

Done.

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_ser...
File runtime/vm/profiler_service.h (right):

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.h:45: TokenPosition token_pos_;
On 2016/03/02 19:02:56, srdjan wrote:
> const

Done.

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.h:47: intptr_t inclusive_ticks_;
On 2016/03/02 19:02:55, srdjan wrote:
> DISALLOW_ALLOCATION

Done.

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.h:101: bool
GetSinglePosition(ProfileFunctionSourcePosition* pfsp);
On 2016/03/02 19:02:56, srdjan wrote:
> Add comment about when is true/false returned.

Done.

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_tes...
File runtime/vm/profiler_test.cc (right):

https://codereview.chromium.org/1758653003/diff/20001/runtime/vm/profiler_tes...
runtime/vm/profiler_test.cc:1941: TEST_CASE(Profiler_SourcePositionOptimized) {
On 2016/03/02 19:02:56, srdjan wrote:
> Disable background compilation

Done here and elsewhere.

[Cutch, 2016-03-02 20:02:32]

Description was changed from

==========
Add source position information to profile

- Fix bug in inlined call token positios.
- Add ProfileFunctionSourcePosition for tracking source positions within
functions.
- Keep a list of ProfileFunctionSourcePosition in each function.
- Add unit test helper functions.
- Add unoptimized unit tests that verify source positions in function profiles.
- Add optimized/inlined unit tests that verify source positions in function
profiles.
==========

to

==========
Add source position information to profile

- Fix bug in inlined call token positios.
- Add ProfileFunctionSourcePosition for tracking source positions within
functions.
- Keep a list of ProfileFunctionSourcePosition in each function.
- Add unit test helper functions.
- Add unoptimized unit tests that verify source positions in function profiles.
- Add optimized/inlined unit tests that verify source positions in function
profiles.

R=srdjan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/58e0ef13fa77cbb52185abd1e92d5341f46b5ae8
==========

[Cutch, 2016-03-02 20:02:35]

Committed patchset #2 (id:20001) manually as
58e0ef13fa77cbb52185abd1e92d5341f46b5ae8 (presubmit successful).