Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: runtime/vm/compiler.cc

Issue 1758653003: Add source position information to profile (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.cc » ('j') | runtime/vm/flow_graph_compiler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index 5d5be9a44306b5900749c8b5337106e77c1c8013..eb2b6a3bcc93943104fbca77f2193420acc0e47b 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -701,7 +701,10 @@ bool CompileParsedFunctionHelper::Compile(CompilationPipeline* pipeline) {
compiler_timeline,
"OptimizationPasses"));
inline_id_to_function.Add(&function);
- inline_id_to_token_pos.Add(function.token_pos());
+ // We do not add the token position now because we don't know the
srdjan 2016/03/02 19:02:55 Maybe add comment that we expect all token positio
Cutch 2016/03/02 19:14:07 Done.
+ // position of the inlined call until later. A side effect of this
+ // is that the length of |inline_id_to_function| is always larger
+ // than the length of |inline_id_to_token_pos| by one.
// Top scope function has no caller (-1).
caller_inline_id.Add(-1);
CSTAT_TIMER_SCOPE(thread(), graphoptimizer_timer);
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.cc » ('j') | runtime/vm/flow_graph_compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698