Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4930)

Unified Diff: chrome/browser/ui/webui/engagement/site_engagement_ui.cc

Issue 1758573002: Make chrome://site-engagement non-polymer and re-enable on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address nit Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/engagement/site_engagement_ui.cc
diff --git a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
index 0452cffa2443d8c01e13196e3efd498cb03a313c..0b1eceaead1143046cb2f8ac419210108e031d6b 100644
--- a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
+++ b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/ui/webui/engagement/site_engagement_ui.h"
+#include <cmath>
#include <utility>
#include "base/macros.h"
@@ -54,7 +55,7 @@ class SiteEngagementUIHandlerImpl : public SiteEngagementUIHandler {
double score) override {
GURL origin_gurl(origin.get());
if (!origin_gurl.is_valid() || score < 0 ||
- score > SiteEngagementScore::kMaxPoints) {
+ score > SiteEngagementScore::kMaxPoints || isnan(score)) {
return;
}
@@ -78,12 +79,6 @@ SiteEngagementUI::SiteEngagementUI(content::WebUI* web_ui)
// Set up the chrome://site-engagement/ source.
scoped_ptr<content::WebUIDataSource> source(
content::WebUIDataSource::Create(chrome::kChromeUISiteEngagementHost));
- source->AddResourcePath("engagement_table.html",
- IDR_SITE_ENGAGEMENT_ENGAGEMENT_TABLE_HTML);
- source->AddResourcePath("engagement_table.css",
- IDR_SITE_ENGAGEMENT_ENGAGEMENT_TABLE_CSS);
- source->AddResourcePath("engagement_table.js",
- IDR_SITE_ENGAGEMENT_ENGAGEMENT_TABLE_JS);
source->AddResourcePath("site_engagement.js", IDR_SITE_ENGAGEMENT_JS);
source->AddResourcePath(
"chrome/browser/ui/webui/engagement/site_engagement.mojom",
« no previous file with comments | « chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698