Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3124)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 1758573002: Make chrome://site-engagement non-polymer and re-enable on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address nit Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index bb85a656a97af5df400504e182f7dde30dca4a6e..a15ca31de3d77acd97e812010524f865d95e849e 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -25,6 +25,7 @@
#include "chrome/browser/ui/webui/crashes_ui.h"
#include "chrome/browser/ui/webui/device_log_ui.h"
#include "chrome/browser/ui/webui/domain_reliability_internals_ui.h"
+#include "chrome/browser/ui/webui/engagement/site_engagement_ui.h"
#include "chrome/browser/ui/webui/flags_ui.h"
#include "chrome/browser/ui/webui/flash_ui.h"
#include "chrome/browser/ui/webui/gcm_internals_ui.h"
@@ -106,7 +107,6 @@
#include "chrome/browser/signin/easy_unlock_service_factory.h"
#include "chrome/browser/ui/webui/copresence_ui.h"
#include "chrome/browser/ui/webui/devtools_ui.h"
-#include "chrome/browser/ui/webui/engagement/site_engagement_ui.h"
#include "chrome/browser/ui/webui/inspect_ui.h"
#include "chrome/browser/ui/webui/md_downloads/md_downloads_ui.h"
#include "chrome/browser/ui/webui/md_history_ui.h"
@@ -419,10 +419,6 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
::switches::AboutInSettingsEnabled())) {
return &NewWebUI<options::OptionsUI>;
}
- if (SiteEngagementService::IsEnabled() &&
- url.host() == chrome::kChromeUISiteEngagementHost) {
- return &NewWebUI<SiteEngagementUI>;
- }
if (url.host() == chrome::kChromeUISyncFileSystemInternalsHost)
return &NewWebUI<SyncFileSystemInternalsUI>;
if (url.host() == chrome::kChromeUISystemInfoHost)
@@ -589,6 +585,11 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
return &NewWebUI<dom_distiller::DomDistillerUi>;
}
+ if (SiteEngagementService::IsEnabled() &&
+ url.host() == chrome::kChromeUISiteEngagementHost) {
+ return &NewWebUI<SiteEngagementUI>;
+ }
+
return NULL;
}
« no previous file with comments | « chrome/browser/resources/engagement/site_engagement.js ('k') | chrome/browser/ui/webui/engagement/site_engagement_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698