Chromium Code Reviews Chromium Code Reviews
Issue 1758573002:
Make chrome://site-engagement non-polymer and re-enable on Android. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/resources/engagement/site_engagement.html |
| diff --git a/chrome/browser/resources/engagement/site_engagement.html b/chrome/browser/resources/engagement/site_engagement.html |
| index cef7e167f8a3f16fba607da04a7d5d2dd9c29774..9700a14e714790fd2356e74424a9308a328dc343 100644 |
| --- a/chrome/browser/resources/engagement/site_engagement.html |
| +++ b/chrome/browser/resources/engagement/site_engagement.html |
| @@ -2,9 +2,6 @@ |
| <head> |
| <title>Site Engagement</title> |
| <meta charset="utf-8"> |
| - <!-- Must be before any other scripts or Polymer imports. --> |
| - <script src="chrome://resources/js/polymer_config.js"></script> |
| - <link rel="import" href="engagement_table.html"> |
| <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> |
| <script src="chrome://resources/js/util.js"></script> |
| <script src="chrome://site-engagement/site_engagement.js"></script> |
| @@ -13,10 +10,79 @@ |
| font-family: 'Roboto', 'Noto', sans-serif; |
| font-size: 14px; |
| } |
| + |
| + table { |
| + border-collapse: collapse; |
| + } |
| + |
| + table td, |
| + table th { |
| + border: 1px solid #777; |
| + padding-left: 4px; |
| + padding-right: 4px; |
| + } |
| + |
| + table th { |
| + background: rgb(224, 236, 255); |
| + cursor: pointer; |
| + padding-bottom: 4px; |
| + padding-top: 4px; |
| + white-space: nowrap; |
| + } |
| + |
| + .engagement-bar { |
| + background-color: black; |
| + height: 2px; |
| + } |
| + |
| + .engagement-bar-cell { |
| + border: none; |
| + } |
| + |
| + .origin-cell { |
| + min-width: 500px; |
| + } |
| + |
| + .score-cell { |
| + text-align: right; |
| + } |
| + |
| + .score-input { |
| + background-color: transparent; |
| + border: none; |
| + text-align: right; |
| + width: 40px; |
| + } |
| + |
| + table tr:hover { |
| + background: rgb(255, 255, 187); |
| + } |
| + |
| + th.sort-column::after { |
| + content: '▲'; |
| + } |
| + |
| + th[sort-reverse].sort-column::after { |
| + content: '▼'; |
| + } |
| </style> |
| </head> |
| <body> |
| <h1>Site Engagement</h1> |
| - <engagement-table id="engagement-table"></engagement-table> |
| + <table> |
| + <thead> |
| + <tr id="engagement-table-header"> |
| + <th onclick="" sort-key="origin"> |
|
tsergeant
2016/03/03 04:00:56
Remove the onclick=""
calamity
2016/03/08 07:35:57
Done.
|
| + Origin |
| + </th> |
| + <th onclick="handleSortColumnTap" sort-key="score" class="sort-column" |
|
tsergeant
2016/03/03 04:00:56
Remove this one too
calamity
2016/03/08 07:35:57
Done.
|
| + sort-reverse> |
| + Points |
| + </th> |
| + </tr> |
| + </thead> |
| + <tbody id="engagement-table-body"> |
| + </tbody> |
| + </table> |
| </body> |
| </html> |
