Chromium Code Reviews Chromium Code Reviews
Issue 1758573002:
Make chrome://site-engagement non-polymer and re-enable on Android. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <!doctype html> | 1 <!doctype html> |
| 2 <head> | 2 <head> |
| 3 <title>Site Engagement</title> | 3 <title>Site Engagement</title> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <!-- Must be before any other scripts or Polymer imports. --> | |
| 6 <script src="chrome://resources/js/polymer_config.js"></script> | |
| 7 <link rel="import" href="engagement_table.html"> | |
| 8 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> | 5 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> |
| 9 <script src="chrome://resources/js/util.js"></script> | 6 <script src="chrome://resources/js/util.js"></script> |
| 10 <script src="chrome://site-engagement/site_engagement.js"></script> | 7 <script src="chrome://site-engagement/site_engagement.js"></script> |
| 11 <style> | 8 <style> |
| 12 body { | 9 body { |
| 13 font-family: 'Roboto', 'Noto', sans-serif; | 10 font-family: 'Roboto', 'Noto', sans-serif; |
| 14 font-size: 14px; | 11 font-size: 14px; |
| 15 } | 12 } |
| 13 | |
| 14 table { | |
| 15 border-collapse: collapse; | |
| 16 } | |
| 17 | |
| 18 table td, | |
| 19 table th { | |
| 20 border: 1px solid #777; | |
| 21 padding-left: 4px; | |
| 22 padding-right: 4px; | |
| 23 } | |
| 24 | |
| 25 table th { | |
| 26 background: rgb(224, 236, 255); | |
| 27 cursor: pointer; | |
| 28 padding-bottom: 4px; | |
| 29 padding-top: 4px; | |
| 30 white-space: nowrap; | |
| 31 } | |
| 32 | |
| 33 .engagement-bar { | |
| 34 background-color: black; | |
| 35 height: 2px; | |
| 36 } | |
| 37 | |
| 38 .engagement-bar-cell { | |
| 39 border: none; | |
| 40 } | |
| 41 | |
| 42 .origin-cell { | |
| 43 min-width: 500px; | |
| 44 } | |
| 45 | |
| 46 .score-cell { | |
| 47 text-align: right; | |
| 48 } | |
| 49 | |
| 50 .score-input { | |
| 51 background-color: transparent; | |
| 52 border: none; | |
| 53 text-align: right; | |
| 54 width: 40px; | |
| 55 } | |
| 56 | |
| 57 table tr:hover { | |
| 58 background: rgb(255, 255, 187); | |
| 59 } | |
| 60 | |
| 61 th.sort-column::after { | |
| 62 content: '▲'; | |
| 63 } | |
| 64 | |
| 65 th[sort-reverse].sort-column::after { | |
| 66 content: '▼'; | |
| 67 } | |
| 16 </style> | 68 </style> |
| 17 </head> | 69 </head> |
| 18 <body> | 70 <body> |
| 19 <h1>Site Engagement</h1> | 71 <h1>Site Engagement</h1> |
| 20 <engagement-table id="engagement-table"></engagement-table> | 72 <table> |
| 73 <thead> | |
| 74 <tr id="engagement-table-header"> | |
| 75 <th onclick="" sort-key="origin"> | |
|
tsergeant
2016/03/03 04:00:56
Remove the onclick=""
calamity
2016/03/08 07:35:57
Done.
| |
| 76 Origin | |
| 77 </th> | |
| 78 <th onclick="handleSortColumnTap" sort-key="score" class="sort-column" | |
|
tsergeant
2016/03/03 04:00:56
Remove this one too
calamity
2016/03/08 07:35:57
Done.
| |
| 79 sort-reverse> | |
| 80 Points | |
| 81 </th> | |
| 82 </tr> | |
| 83 </thead> | |
| 84 <tbody id="engagement-table-body"> | |
| 85 </tbody> | |
| 86 </table> | |
| 21 </body> | 87 </body> |
| 22 </html> | 88 </html> |
| OLD | NEW |
