Issue 1758553004: Optimizations to histogram protobuf encoding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1758553004: Optimizations to histogram protobuf encoding. (Closed)

Created:
4 years, 9 months ago by Alexei Svitkine (slow)

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Optimizations to histogram protobuf encoding. Omits several fields from being sent if their value is one of the common field values. BUG=590765 Review URL: https://codereview.chromium.org/1744283002 Cr-Commit-Position: refs/heads/master@{#378364} (cherry picked from commit 0955394cb22f2b84de5a9d3a804c0f379b3455db) Committed: https://chromium.googlesource.com/chromium/src/+/fbb3c78c166261745387a9a6a86d42b05dcf2115

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	components/metrics/histogram_encoder.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	M	components/metrics/proto/histogram_event.proto	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Alexei Svitkine (slow)

4 years, 9 months ago (2016-03-02 18:18:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fbb3c78c166261745387a9a6a86d42b05dcf2115.