Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1744283002: Optimizations to histogram protobuf encoding. (Closed)

Created:
4 years, 9 months ago by Alexei Svitkine (slow)
Modified:
4 years, 9 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimizations to histogram protobuf encoding. Omits several fields from being sent if their value is one of the common field values. BUG=590765 Committed: https://crrev.com/0955394cb22f2b84de5a9d3a804c0f379b3455db Cr-Commit-Position: refs/heads/master@{#378364}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M components/metrics/histogram_encoder.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M components/metrics/proto/histogram_event.proto View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Alexei Svitkine (slow)
Matches internal changes under http://CL/115863031
4 years, 9 months ago (2016-02-29 18:24:23 UTC) #3
rkaplow
lgtm https://codereview.chromium.org/1744283002/diff/1/components/metrics/histogram_encoder.cc File components/metrics/histogram_encoder.cc (right): https://codereview.chromium.org/1744283002/diff/1/components/metrics/histogram_encoder.cc#newcode40 components/metrics/histogram_encoder.cc:40: if (count != 1) Might just add a ...
4 years, 9 months ago (2016-02-29 22:46:44 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/1744283002/diff/1/components/metrics/histogram_encoder.cc File components/metrics/histogram_encoder.cc (right): https://codereview.chromium.org/1744283002/diff/1/components/metrics/histogram_encoder.cc#newcode40 components/metrics/histogram_encoder.cc:40: if (count != 1) On 2016/02/29 22:46:44, rkaplow wrote: ...
4 years, 9 months ago (2016-02-29 22:55:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744283002/20001
4 years, 9 months ago (2016-02-29 22:56:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 01:42:45 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 01:44:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0955394cb22f2b84de5a9d3a804c0f379b3455db
Cr-Commit-Position: refs/heads/master@{#378364}

Powered by Google App Engine
This is Rietveld 408576698