Optimizations to histogram protobuf encoding.

Optimizations to histogram protobuf encoding.

Omits several fields from being sent if their value is one of the
common field values.

BUG=590765
Committed: https://crrev.com/0955394cb22f2b84de5a9d3a804c0f379b3455db
Cr-Commit-Position: refs/heads/master@{#378364}

[Alexei Svitkine (slow), 2016-02-29 17:18:43]

Description was changed from

==========
Optimizations to histogram protobuf encoding.

Omits several fields from being sent if their value is one of the
common field values.

BUG=tbd
==========

to

==========
Optimizations to histogram protobuf encoding.

Omits several fields from being sent if their value is one of the
common field values.

BUG=590765
==========

[Alexei Svitkine (slow), 2016-02-29 18:24:23]

asvitkine@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Alexei Svitkine (slow), 2016-02-29 18:24:23]

Matches internal changes under http://CL/115863031

[rkaplow, 2016-02-29 22:46:44]

lgtm

https://codereview.chromium.org/1744283002/diff/1/components/metrics/histogra...
File components/metrics/histogram_encoder.cc (right):

https://codereview.chromium.org/1744283002/diff/1/components/metrics/histogra...
components/metrics/histogram_encoder.cc:40: if (count != 1)
Might just add a comment that 1 is the default in the proto. Less worried about
sum since 0 is a pretty natural default but 1 is not so looks slightly odd.

[Alexei Svitkine (slow), 2016-02-29 22:55:54]

https://codereview.chromium.org/1744283002/diff/1/components/metrics/histogra...
File components/metrics/histogram_encoder.cc (right):

https://codereview.chromium.org/1744283002/diff/1/components/metrics/histogra...
components/metrics/histogram_encoder.cc:40: if (count != 1)
On 2016/02/29 22:46:44, rkaplow wrote:
> Might just add a comment that 1 is the default in the proto. Less worried
about
> sum since 0 is a pretty natural default but 1 is not so looks slightly odd.

Done.

[Alexei Svitkine (slow), 2016-02-29 22:55:59]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-02-29 22:55:59]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/1744283002/#ps20001
(title: "Add a comment.")

[commit-bot: I haz the power, 2016-02-29 22:56:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744283002/20001

[commit-bot: I haz the power, 2016-03-01 01:42:45]

Description was changed from

==========
Optimizations to histogram protobuf encoding.

Omits several fields from being sent if their value is one of the
common field values.

BUG=590765
==========

to

==========
Optimizations to histogram protobuf encoding.

Omits several fields from being sent if their value is one of the
common field values.

BUG=590765
==========

[commit-bot: I haz the power, 2016-03-01 01:42:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-01 01:44:21]

Description was changed from

==========
Optimizations to histogram protobuf encoding.

Omits several fields from being sent if their value is one of the
common field values.

BUG=590765
==========

to

==========
Optimizations to histogram protobuf encoding.

Omits several fields from being sent if their value is one of the
common field values.

BUG=590765

Committed: https://crrev.com/0955394cb22f2b84de5a9d3a804c0f379b3455db
Cr-Commit-Position: refs/heads/master@{#378364}
==========

[commit-bot: I haz the power, 2016-03-01 01:44:21]

Patchset 2 (id:??) landed as
https://crrev.com/0955394cb22f2b84de5a9d3a804c0f379b3455db
Cr-Commit-Position: refs/heads/master@{#378364}