Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1758463002: Add browser test cases for tab and audio share, which are new functionality of desktop share. (Closed)

Created:
4 years, 9 months ago by qiangchen
Modified:
4 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add browser test cases for tab and audio share, which are new functionality of desktop share. BUG=557222 Committed: https://crrev.com/4921860f7c92ea15a3447bd52d58394e02cb28d9 Cr-Commit-Position: refs/heads/master@{#380448}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Resolve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -49 lines) Patch
M chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc View 1 5 chunks +70 lines, -34 lines 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_base.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/desktop_capture/test.js View 1 4 chunks +83 lines, -12 lines 0 comments Download
M content/public/browser/desktop_media_id.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
qiangchen
Can you take a look? Feel free to tell me, if you can think of ...
4 years, 9 months ago (2016-03-01 23:01:29 UTC) #3
GeorgeZ
Other test cases you may consider tab with audio, screen with/without audio. window without audio. ...
4 years, 9 months ago (2016-03-01 23:23:23 UTC) #4
qiangchen
This CL add several test cases (tab and audio aspect) for desktop capture api test. ...
4 years, 9 months ago (2016-03-03 23:56:02 UTC) #11
qiangchen
A reminder for this CL.
4 years, 9 months ago (2016-03-09 17:25:37 UTC) #12
Ken Rockot(use gerrit already)
Generally looks OK to me - I'll be happy to rubber stamp as extensions OWNER ...
4 years, 9 months ago (2016-03-09 18:44:40 UTC) #13
qiangchen
Hi, Avi@ Can you take a look at this CL. More specifically, deskop_media_id.h, where we ...
4 years, 9 months ago (2016-03-09 21:44:17 UTC) #15
GeorgeZ
lgtm
4 years, 9 months ago (2016-03-09 21:45:03 UTC) #16
Avi (use Gerrit)
desktop_media_id.h lgtm
4 years, 9 months ago (2016-03-09 22:15:23 UTC) #17
Ken Rockot(use gerrit already)
rs lgtm for extensions
4 years, 9 months ago (2016-03-09 22:16:44 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758463002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758463002/120001
4 years, 9 months ago (2016-03-10 17:05:17 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 9 months ago (2016-03-10 19:54:31 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 19:55:43 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4921860f7c92ea15a3447bd52d58394e02cb28d9
Cr-Commit-Position: refs/heads/master@{#380448}

Powered by Google App Engine
This is Rietveld 408576698