Add browser test cases for tab and audio share, which are new functionality of desktop share.

Add browser test cases for tab and audio share, which are new functionality of desktop share.

BUG=557222
Committed: https://crrev.com/4921860f7c92ea15a3447bd52d58394e02cb28d9
Cr-Commit-Position: refs/heads/master@{#380448}

[qiangchen, 2016-03-01 22:58:59]

Description was changed from

==========
Add browser test cases for tab and audio share, which are new functionality of
desktop share.

BUG=557222
==========

to

==========
Add browser test cases for tab and audio share, which are new functionality of
desktop share.

BUG=557222
==========

[qiangchen, 2016-03-01 22:58:59]

qiangchen@chromium.org changed reviewers:
+ gyzhou@chromium.org

[qiangchen, 2016-03-01 23:01:29]

Can you take a look?
Feel free to tell me, if you can think of other test cases we can add.

[GeorgeZ, 2016-03-01 23:23:23]

Other test cases you may consider
 
tab with audio,
screen with/without audio.
window without audio.

['tab'] only in chooseDesktopMedia.

https://codereview.chromium.org/1758463002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
(right):

https://codereview.chromium.org/1758463002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc:173:
media_id_tab_audio.audio_share = true;
You may modify constructor DesktopMediaID(Type type, Id id) to
DesktopMediaID(Type type, Id id, bool audio=false) and so on.

[qiangchen, 2016-03-03 22:02:19]

Patchset #2 (id:20001) has been deleted

[qiangchen, 2016-03-03 22:02:29]

Patchset #2 (id:40001) has been deleted

[qiangchen, 2016-03-03 22:02:44]

Patchset #2 (id:60001) has been deleted

[qiangchen, 2016-03-03 22:02:58]

Patchset #2 (id:80001) has been deleted

[qiangchen, 2016-03-03 22:15:11]

Patchset #2 (id:100001) has been deleted

[qiangchen, 2016-03-03 23:56:01]

qiangchen@chromium.org changed reviewers:
+ nasko@chromium.org, rockot@chromium.org

[qiangchen, 2016-03-03 23:56:02]

This CL add several test cases (tab and audio aspect) for desktop capture api
test.

PTAL.

Thanks.

https://codereview.chromium.org/1758463002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
(right):

https://codereview.chromium.org/1758463002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc:173:
media_id_tab_audio.audio_share = true;
On 2016/03/01 23:23:23, GeorgeZ wrote:
> You may modify constructor DesktopMediaID(Type type, Id id) to
> DesktopMediaID(Type type, Id id, bool audio=false) and so on.

Done.

[qiangchen, 2016-03-09 17:25:37]

A reminder for this CL.

[Ken Rockot(use gerrit already), 2016-03-09 18:44:40]

Generally looks OK to me - I'll be happy to rubber stamp as extensions OWNER
pending other reviewers' approval

[qiangchen, 2016-03-09 21:42:06]

qiangchen@chromium.org changed reviewers:
+ avi@chromium.org
- nasko@chromium.org

[qiangchen, 2016-03-09 21:44:17]

Hi, Avi@

Can you take a look at this CL.
More specifically, deskop_media_id.h, where we simply add a constructor for test
code to use.

Thanks.

[GeorgeZ, 2016-03-09 21:45:03]

lgtm

[Avi (use Gerrit), 2016-03-09 22:15:23]

desktop_media_id.h lgtm

[Ken Rockot(use gerrit already), 2016-03-09 22:16:44]

rs lgtm for extensions

[qiangchen, 2016-03-10 17:04:56]

The CQ bit was checked by qiangchen@chromium.org

[commit-bot: I haz the power, 2016-03-10 17:05:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1758463002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1758463002/120001

[commit-bot: I haz the power, 2016-03-10 19:54:30]

Description was changed from

==========
Add browser test cases for tab and audio share, which are new functionality of
desktop share.

BUG=557222
==========

to

==========
Add browser test cases for tab and audio share, which are new functionality of
desktop share.

BUG=557222
==========

[commit-bot: I haz the power, 2016-03-10 19:54:31]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-03-10 19:55:40]

Description was changed from

==========
Add browser test cases for tab and audio share, which are new functionality of
desktop share.

BUG=557222
==========

to

==========
Add browser test cases for tab and audio share, which are new functionality of
desktop share.

BUG=557222

Committed: https://crrev.com/4921860f7c92ea15a3447bd52d58394e02cb28d9
Cr-Commit-Position: refs/heads/master@{#380448}
==========

[commit-bot: I haz the power, 2016-03-10 19:55:43]

Patchset 2 (id:??) landed as
https://crrev.com/4921860f7c92ea15a3447bd52d58394e02cb28d9
Cr-Commit-Position: refs/heads/master@{#380448}