chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc - Issue 1758463002: Add browser test cases for tab and audio share, which are new functionality of desktop share.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

Issue 1758463002: Add browser test cases for tab and audio share, which are new functionality of desktop share. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/desktop_capture/desktop_capture_base.h ('k') | chrome/test/data/extensions/api_test/desktop_capture/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

diff --git a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

index 4e0903d690cd01c3fbf728dfa7440c0cbeb1f91e..d30e2408c888c09f4323378f2bdaf992e5fa0ac5 100644

--- a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

+++ b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

@@ -120,8 +120,8 @@ bool DesktopCaptureChooseDesktopMediaFunctionBase::Execute(

web_contents->GetTopLevelNativeWindow();

scoped_ptr<DesktopMediaList> media_list;

if (g_picker_factory) {

- media_list = g_picker_factory->CreateModel(

- show_screens, show_windows);

+ media_list = g_picker_factory->CreateModel(show_screens, show_windows,

+ show_tabs, request_audio);

picker_ = g_picker_factory->CreatePicker();

} else {

std::vector<scoped_ptr<DesktopMediaList>> media_lists;