Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1758413002: Do not pass scrollPosition to updateScrollbars at every callsite (Closed)

Created:
4 years, 9 months ago by pdr.
Modified:
4 years, 9 months ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not pass scrollPosition to updateScrollbars at every callsite More followup cleanup to the scroll position code. This is a minor refactoring to push the scroll position double concent into updateScrollbars since it does not need to be plumbed at every callsite. scrollPositionDouble has some subtlety (see comment above it) which is easy to mess up. Committed: https://crrev.com/d12c2b3ab25398ae385564c7506f0e4b598169eb Cr-Commit-Position: refs/heads/master@{#380478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
pdr.
Last patch for this messy code. Just a simple cleanup.
4 years, 9 months ago (2016-03-03 21:35:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758413002/1
4 years, 9 months ago (2016-03-03 21:35:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 23:12:13 UTC) #6
chrishtr
lgtm
4 years, 9 months ago (2016-03-10 17:07:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758413002/1
4 years, 9 months ago (2016-03-10 17:07:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/36557)
4 years, 9 months ago (2016-03-10 18:21:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758413002/1
4 years, 9 months ago (2016-03-10 20:58:30 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 22:11:57 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 22:13:20 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d12c2b3ab25398ae385564c7506f0e4b598169eb
Cr-Commit-Position: refs/heads/master@{#380478}

Powered by Google App Engine
This is Rietveld 408576698