Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1758413002: Do not pass scrollPosition to updateScrollbars at every callsite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 601 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 612
613 enum ComputeScrollbarExistenceOption { 613 enum ComputeScrollbarExistenceOption {
614 FirstPass, 614 FirstPass,
615 Incremental 615 Incremental
616 }; 616 };
617 void computeScrollbarExistence(bool& newHasHorizontalScrollbar, bool& newHas VerticalScrollbar, const IntSize& docSize, ComputeScrollbarExistenceOption = Fir stPass) const; 617 void computeScrollbarExistence(bool& newHasHorizontalScrollbar, bool& newHas VerticalScrollbar, const IntSize& docSize, ComputeScrollbarExistenceOption = Fir stPass) const;
618 void updateScrollbarGeometry(); 618 void updateScrollbarGeometry();
619 IntRect adjustScrollbarRectForResizer(const IntRect&, Scrollbar&); 619 IntRect adjustScrollbarRectForResizer(const IntRect&, Scrollbar&);
620 620
621 // Called to update the scrollbars to accurately reflect the state of the vi ew. 621 // Called to update the scrollbars to accurately reflect the state of the vi ew.
622 void updateScrollbars(const DoubleSize& desiredOffset); 622 void updateScrollbars();
623 623
624 class InUpdateScrollbarsScope { 624 class InUpdateScrollbarsScope {
625 STACK_ALLOCATED(); 625 STACK_ALLOCATED();
626 public: 626 public:
627 explicit InUpdateScrollbarsScope(FrameView* view) 627 explicit InUpdateScrollbarsScope(FrameView* view)
628 : m_scope(view->m_inUpdateScrollbars, true) 628 : m_scope(view->m_inUpdateScrollbars, true)
629 { } 629 { }
630 private: 630 private:
631 TemporaryChange<bool> m_scope; 631 TemporaryChange<bool> m_scope;
632 }; 632 };
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
928 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 928 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
929 setIsVisuallyNonEmpty(); 929 setIsVisuallyNonEmpty();
930 } 930 }
931 931
932 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 932 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
933 DEFINE_TYPE_CASTS(FrameView, ScrollableArea, scrollableArea, scrollableArea->isF rameView(), scrollableArea.isFrameView()); 933 DEFINE_TYPE_CASTS(FrameView, ScrollableArea, scrollableArea, scrollableArea->isF rameView(), scrollableArea.isFrameView());
934 934
935 } // namespace blink 935 } // namespace blink
936 936
937 #endif // FrameView_h 937 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698