Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issue 1758383002: Revert of Use FontFallbackPriority Fonts in FontFallbackIterator (Closed)

Created:
4 years, 9 months ago by Dmitry Titov
Modified:
4 years, 9 months ago
Reviewers:
drott, eae, behdad
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use FontFallbackPriority Fonts in FontFallbackIterator (patchset #6 id:100001 of https://codereview.chromium.org/1672553004/ ) Reason for revert: Broke layout tests: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/7227 See http://crbug.com/591778 Original issue's description: > Use FontFallbackPriority Fonts in FontFallbackIterator > > Now that the pieces are in place, use the emoji and symbol fonts in > FontFallbackIterator. Previously FontCache's character fallback > functions were extended so that they take FontFallbackPriority into > account. These functions can now be used in FontFallbackIterator as a > fallback priority stage where those fonts are used as the first fallback > font in order to correctly distinguish between emoji and text > presentation emoji. > > BUG=549571 > R=eae, behdad > > Committed: https://crrev.com/978d4a1ba3d9654905378de192e64f9232e62798 > Cr-Commit-Position: refs/heads/master@{#379036} TBR=behdad@chromium.org,eae@chromium.org,drott@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549571 Committed: https://crrev.com/82a0b1d5eeb238835132357f7988f3ff8f8f63fb Cr-Commit-Position: refs/heads/master@{#379062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -72 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDataRange.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h View 5 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp View 4 chunks +8 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dmitry Titov
Created Revert of Use FontFallbackPriority Fonts in FontFallbackIterator
4 years, 9 months ago (2016-03-03 19:45:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758383002/1
4 years, 9 months ago (2016-03-03 19:45:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 19:46:34 UTC) #4
eae
On 2016/03/03 19:46:34, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) The ...
4 years, 9 months ago (2016-03-03 19:48:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/82a0b1d5eeb238835132357f7988f3ff8f8f63fb Cr-Commit-Position: refs/heads/master@{#379062}
4 years, 9 months ago (2016-03-03 19:48:34 UTC) #7
drott
4 years, 9 months ago (2016-03-04 07:22:42 UTC) #8
Message was sent while issue was closed.
In fairness, dimich@ contacted me on Hangouts, but I was probably asleep or
winding down :-) No worries, relanding in:
https://codereview.chromium.org/1764933002

Powered by Google App Engine
This is Rietveld 408576698