Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1764933002: Reland: Use FontFallbackPriority Fonts in FontFallbackIterator (Closed)

Created:
4 years, 9 months ago by drott
Modified:
4 years, 9 months ago
Reviewers:
eae, behdad
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, vmpstr+blinkwatch_chromium.org, dshwang, jbroman, Justin Novosad, blink-reviews-platform-graphics_chromium.org, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Use FontFallbackPriority Fonts in FontFallbackIterator Now that the pieces are in place, use the emoji and symbol fonts in FontFallbackIterator. Previously FontCache's character fallback functions were extended so that they take FontFallbackPriority into account. These functions can now be used in FontFallbackIterator as a fallback priority stage where those fonts are used as the first fallback font in order to correctly distinguish between emoji and text presentation emoji. Relanded after revert in https://codereview.chromium.org/1758383002/ Rebaselining the test results since now the emoji font is used more often. Original issue LGTM'ed in https://codereview.chromium.org/1672553004/ BUG=549571, 591778 TBR=eae, behdad Committed: https://crrev.com/508edd3841b53f2f6063c6a6ef58f34a4e41e71c Cr-Commit-Position: refs/heads/master@{#379249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDataRange.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h View 5 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp View 4 chunks +45 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764933002/1
4 years, 9 months ago (2016-03-04 07:18:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 08:47:03 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 08:48:16 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/508edd3841b53f2f6063c6a6ef58f34a4e41e71c
Cr-Commit-Position: refs/heads/master@{#379249}

Powered by Google App Engine
This is Rietveld 408576698