Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1758163002: Revert of Initial round of cleanups now all events go through StartRequest. (Closed)

Created:
4 years, 9 months ago by Dmitry Titov
Modified:
4 years, 9 months ago
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor-fetch-event
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Initial round of cleanups now all events go through StartRequest. (patchset #2 id:20001 of https://codereview.chromium.org/1652353003/ ) Reason for revert: Speculative revert to see if it affects memory leaks started yesterday: http://crbug.com/591596 Will reland if it is innocent. Original issue's description: > Initial round of cleanups now all events go through StartRequest. > > The RequestType enum is no longer needed, and AddRequest can get merged > into StartRequest. > > BUG=570820 > > Committed: https://crrev.com/72feb1c098834b8734b7caba1de75331a9d321a8 > Cr-Commit-Position: refs/heads/master@{#378537} TBR=nhiroki@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=570820 Committed: https://chromium.googlesource.com/chromium/src/+/277e2f36d27658fad92573f21b79108af7a5e160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -51 lines) Patch
M content/browser/service_worker/service_worker_version.h View 2 chunks +26 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 8 chunks +106 lines, -51 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dmitry Titov
Created Revert of Initial round of cleanups now all events go through StartRequest.
4 years, 9 months ago (2016-03-03 02:04:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758163002/1
4 years, 9 months ago (2016-03-03 02:05:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758163002/1
4 years, 9 months ago (2016-03-03 02:31:38 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/277e2f36d27658fad92573f21b79108af7a5e160 Cr-Commit-Position: refs/heads/master@{#378927}
4 years, 9 months ago (2016-03-03 02:47:00 UTC) #6
Dmitry Titov
Committed patchset #1 (id:1) manually as 277e2f36d27658fad92573f21b79108af7a5e160 (presubmit successful).
4 years, 9 months ago (2016-03-03 02:47:39 UTC) #8
Dmitry Titov
4 years, 9 months ago (2016-03-03 02:51:05 UTC) #9
Message was sent while issue was closed.
Landed manually:
https://chromium.googlesource.com/chromium/src/+/277e2f36d27658fad92573f21b79...

Powered by Google App Engine
This is Rietveld 408576698