Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1758163002: Revert of Initial round of cleanups now all events go through StartRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-fetch-event
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index 34601a39ea0808100f06c1b7bb181e1dd0727f6f..07b6e9c59b1e62676e339edb100782fb9c6536cf 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -373,14 +373,21 @@
class Metrics;
class PingController;
+ enum RequestType {
+ REQUEST_CUSTOM,
+ NUM_REQUEST_TYPES
+ };
+
struct RequestInfo {
RequestInfo(int id,
+ RequestType type,
ServiceWorkerMetrics::EventType event_type,
const base::TimeTicks& expiration,
TimeoutBehavior timeout_behavior);
~RequestInfo();
bool operator>(const RequestInfo& other) const;
int id;
+ RequestType type;
ServiceWorkerMetrics::EventType event_type;
base::TimeTicks expiration;
TimeoutBehavior timeout_behavior;
@@ -587,6 +594,25 @@
// and records metrics about startup.
void RecordStartWorkerResult(ServiceWorkerStatusCode status);
+ template <typename IDMAP>
+ void RemoveCallbackAndStopIfRedundant(IDMAP* callbacks, int request_id);
+
+ template <typename CallbackType>
+ int AddRequest(
+ const CallbackType& callback,
+ IDMap<PendingRequest<CallbackType>, IDMapOwnPointer>* callback_map,
+ RequestType request_type,
+ ServiceWorkerMetrics::EventType event_type);
+
+ template <typename CallbackType>
+ int AddRequestWithExpiration(
+ const CallbackType& callback,
+ IDMap<PendingRequest<CallbackType>, IDMapOwnPointer>* callback_map,
+ RequestType request_type,
+ ServiceWorkerMetrics::EventType event_type,
+ base::TimeTicks expiration,
+ TimeoutBehavior timeout_behavior);
+
bool MaybeTimeOutRequest(const RequestInfo& info);
void SetAllRequestExpirations(const base::TimeTicks& expiration);
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698