Issue 17581004: Move ExitFrame::ComputeStackPointer from frames-<arch>.cc to frames.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17581004: Move ExitFrame::ComputeStackPointer from frames-<arch>.cc to frames.cc (Closed)

Created:
7 years, 6 months ago by yurys

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne, loislo

CC:
v8-dev, alph

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move ExitFrame::ComputeStackPointer from frames-<arch>.cc to frames.cc The method has identical implementation for all architectures. Moved it into frames.cc Drive-by: deleted SafeStackFrameIterator::is_working_iterator_, SafeStackFrameIterator::iteration_done_ is used instead. BUG=None R=loislo@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15293

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -35 lines)			Patch
M	src/arm/frames-arm.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/frames.h	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/frames.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/ia32/frames-ia32.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	src/mips/frames-mips.cc	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	src/x64/frames-x64.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 6 months ago (2013-06-24 13:28:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r15293 (presubmit successful).

Expand Messages | Collapse Messages