Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: src/frames.h

Issue 17581004: Move ExitFrame::ComputeStackPointer from frames-<arch>.cc to frames.cc (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/frames-arm.cc ('k') | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index 53668d09d98e9a89f1f01a6f6ea73184a45e0bf8..5c3acf2b861af6209c647e35b123df8dc39258f3 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -860,7 +860,6 @@ class JavaScriptFrameIterator BASE_EMBEDDED {
// functions in runtime.js.
class StackTraceFrameIterator: public JavaScriptFrameIterator {
public:
- StackTraceFrameIterator();
explicit StackTraceFrameIterator(Isolate* isolate);
void Advance();
@@ -876,22 +875,22 @@ class SafeStackFrameIterator BASE_EMBEDDED {
Address low_bound, Address high_bound);
StackFrame* frame() const {
- ASSERT(is_working_iterator_);
+ ASSERT(!iteration_done_);
return iterator_.frame();
}
- bool done() const { return iteration_done_ ? true : iterator_.done(); }
+ bool done() const { return iteration_done_ || iterator_.done(); }
void Advance();
static bool is_active(Isolate* isolate);
+ private:
static bool IsWithinBounds(
Address low_bound, Address high_bound, Address addr) {
return low_bound <= addr && addr <= high_bound;
}
- private:
class StackAddressValidator {
public:
StackAddressValidator(Address low_bound, Address high_bound)
@@ -941,7 +940,6 @@ class SafeStackFrameIterator BASE_EMBEDDED {
StackAddressValidator stack_validator_;
const bool is_valid_top_;
const bool is_valid_fp_;
- const bool is_working_iterator_;
bool iteration_done_;
StackFrameIterator iterator_;
};
« no previous file with comments | « src/arm/frames-arm.cc ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698