Issue 17580010: Make a Persistent ctor take const Persistent& instead of Persistent&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17580010: Make a Persistent ctor take const Persistent& instead of Persistent&. (Closed)

Created:
7 years, 6 months ago by marja

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne, dcarney, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/v8.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

marja

svenpanne, ptal Idk why it wasn't const& to begin with, do you?

7 years, 6 months ago (2013-06-24 09:27:26 UTC) #1

dcarney

On 2013/06/24 09:27:26, marja wrote: > svenpanne, ptal > > Idk why it wasn't const& ...

7 years, 6 months ago (2013-06-24 09:29:02 UTC) #2

Michael Starzinger

7 years, 6 months ago (2013-06-24 09:35:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r15278 (presubmit successful).