Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: include/v8.h

Issue 17580010: Make a Persistent ctor take const Persistent& instead of Persistent&. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 491 matching lines...) Expand 10 before | Expand all | Expand 10 after
502 502
503 /** 503 /**
504 * A constructor that creates a new global cell pointing to that. In contrast 504 * A constructor that creates a new global cell pointing to that. In contrast
505 * to the copy constructor, this creates a new persistent handle which needs 505 * to the copy constructor, this creates a new persistent handle which needs
506 * to be separately disposed. 506 * to be separately disposed.
507 */ 507 */
508 template <class S> V8_INLINE(Persistent(Isolate* isolate, Handle<S> that)) 508 template <class S> V8_INLINE(Persistent(Isolate* isolate, Handle<S> that))
509 : val_(New(isolate, *that)) { } 509 : val_(New(isolate, *that)) { }
510 510
511 template <class S> V8_INLINE(Persistent(Isolate* isolate, 511 template <class S> V8_INLINE(Persistent(Isolate* isolate,
512 Persistent<S>& that)) // NOLINT 512 const Persistent<S>& that)) // NOLINT
513 : val_(New(isolate, *that)) { } 513 : val_(New(isolate, *that)) { }
514 514
515 #else 515 #else
516 /** 516 /**
517 * Creates an empty persistent handle that doesn't point to any 517 * Creates an empty persistent handle that doesn't point to any
518 * storage cell. 518 * storage cell.
519 */ 519 */
520 V8_INLINE(Persistent()) : Handle<T>() { } 520 V8_INLINE(Persistent()) : Handle<T>() { }
521 521
522 /** 522 /**
(...skipping 5849 matching lines...) Expand 10 before | Expand all | Expand 10 after
6372 6372
6373 6373
6374 } // namespace v8 6374 } // namespace v8
6375 6375
6376 6376
6377 #undef V8EXPORT 6377 #undef V8EXPORT
6378 #undef TYPE_CHECK 6378 #undef TYPE_CHECK
6379 6379
6380 6380
6381 #endif // V8_H_ 6381 #endif // V8_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698