Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1757913002: Revert of Generate Signed Distance Field directly from vector path (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
reviews_skia.org, developer_arm.com
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Generate Signed Distance Field directly from vector path (patchset #13 id:240001 of https://codereview.chromium.org/1643143002/ ) Reason for revert: This patch seems to be generating the assert: GrDistanceFieldGenFromVector.cpp:748: fatal error: ""0 && \"Winding number should be zero at the end of a scan line.\""" Original issue's description: > Generate Signed Distance Field directly from vector path > > Add SkGenerateDistanceFieldFromPath API to generate signed distance field directly from SkPath. > Currently only support even odd fill type. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643143002 > > Committed: https://skia.googlesource.com/skia/+/4de97a64e8829323a7070b623411d9f9ddb0cd0f TBR=bsalomon@google.com,jvanverth@google.com,mtklein@google.com,wasim.abbas@arm.com,joel.liang@arm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2a7cf5f5090fb6489284547850d308b33086fad9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -818 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D src/gpu/GrDistanceFieldGenFromVector.h View 1 chunk +0 lines, -29 lines 0 comments Download
D src/gpu/GrDistanceFieldGenFromVector.cpp View 1 chunk +0 lines, -761 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 7 chunks +37 lines, -15 lines 0 comments Download
M src/gpu/text/GrFontScaler.cpp View 2 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Generate Signed Distance Field directly from vector path
4 years, 9 months ago (2016-03-02 13:36:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757913002/1
4 years, 9 months ago (2016-03-02 13:36:25 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 13:36:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2a7cf5f5090fb6489284547850d308b33086fad9

Powered by Google App Engine
This is Rietveld 408576698